Skip to content

๐Ÿงช [testing] Add test for valkey_queue_enabled #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

๐Ÿงช [testing] Add test for valkey_queue_enabled #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions backend/tests/test_valkey_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,26 @@
from app.settings import settings


def test_valkey_queue_enabled(monkeypatch: pytest.MonkeyPatch) -> None:

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ“ Maintainability & Code Quality | ๐ŸŸ  Major | โšก Quick win

๊ณต๊ฐœ ํ…Œ์ŠคํŠธ ํ•จ์ˆ˜์— docstring์„ ์ถ”๊ฐ€ํ•˜์„ธ์š”.

test_valkey_queue_enabled๋Š” ๊ณต๊ฐœ ํ•จ์ˆ˜ ์ •์˜์ด๋ฉฐ docstring์ด ์—†์Šต๋‹ˆ๋‹ค. ๋ฐฑ์—”๋“œ ์ข…๋ฅ˜์™€ Valkey URL ๋˜๋Š” Sentinel ํ˜ธ์ŠคํŠธ ์กฐํ•ฉ์„ ๊ฒ€์ฆํ•œ๋‹ค๋Š” ์„ค๋ช…์„ ์ถ”๊ฐ€ํ•˜์„ธ์š”.

์ˆ˜์ • ์˜ˆ์‹œ 
 def test_valkey_queue_enabled(monkeypatch: pytest.MonkeyPatch) -> None:
+    """๋ฐฑ์—”๋“œ์™€ Valkey ์„ค์ •์— ๋”ฐ๋ฅธ ํ ํ™œ์„ฑํ™”๋ฅผ ๊ฒ€์ฆํ•œ๋‹ค."""

As per coding guidelines: backend/**/*.py: Keep backend Python code strictly typed; public definitions require docstrings, and checked modules must satisfy interrogate's 100% fail-under threshold.

๐Ÿ“ Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def test_valkey_queue_enabled(monkeypatch: pytest.MonkeyPatch) -> None:
def test_valkey_queue_enabled(monkeypatch: pytest.MonkeyPatch) -> None:
"""๋ฐฑ์—”๋“œ์™€ Valkey ์„ค์ •์— ๋”ฐ๋ฅธ ํ ํ™œ์„ฑํ™”๋ฅผ ๊ฒ€์ฆํ•œ๋‹ค."""
๐Ÿค– Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend/tests/test_valkey_queue.py` at line 12, ํ…Œ์ŠคํŠธ ํ•จ์ˆ˜
test_valkey_queue_enabled์— docstring์„ ์ถ”๊ฐ€ํ•ด, ๋ฐฑ์—”๋“œ ์ข…๋ฅ˜์™€ Valkey URL ๋˜๋Š” Sentinel ํ˜ธ์ŠคํŠธ
์กฐํ•ฉ์„ ๊ฒ€์ฆํ•œ๋‹ค๋Š” ๋‚ด์šฉ์„ ๋ช…ํ™•ํžˆ ์„ค๋ช…ํ•˜์„ธ์š”. ํ•จ์ˆ˜์˜ ํ…Œ์ŠคํŠธ ๋™์ž‘๊ณผ ํƒ€์ž… ์ฃผ์„์€ ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•˜๊ณ , interrogate๊ฐ€ ๊ณต๊ฐœ ํ•จ์ˆ˜ ๋ฌธ์„œํ™” ๊ธฐ์ค€์„
ํ†ต๊ณผํ•˜๋„๋ก ์ž‘์„ฑํ•˜์„ธ์š”.

Source: Coding guidelines

monkeypatch.setattr(settings, "job_queue_backend", "postgres")
assert valkey_queue.valkey_queue_enabled() is False

monkeypatch.setattr(settings, "job_queue_backend", "valkey")
monkeypatch.setattr(settings, "valkey_url", None)
monkeypatch.setattr(settings, "valkey_sentinel_hosts", None)
assert valkey_queue.valkey_queue_enabled() is False

monkeypatch.setattr(settings, "job_queue_backend", "valkey")
monkeypatch.setattr(settings, "valkey_url", "redis://127.0.0.1:6379/0")
monkeypatch.setattr(settings, "valkey_sentinel_hosts", None)
assert valkey_queue.valkey_queue_enabled() is True

monkeypatch.setattr(settings, "job_queue_backend", "valkey")
monkeypatch.setattr(settings, "valkey_url", None)
monkeypatch.setattr(settings, "valkey_sentinel_hosts", "valkey-a.local:26379")
assert valkey_queue.valkey_queue_enabled() is True


def test_valkey_queue_summary_uses_sentinel_without_secrets(
monkeypatch: pytest.MonkeyPatch,
) -> None:
Expand Down
Loading