Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix control character injection in schema fields #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 3 commits into from
Closed

πŸ›‘οΈ Sentinel: [MEDIUM] Fix control character injection in schema fields #790

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40876cf
Harden Pydantic schemas against control characters
seonghobae Aug 8, 2026
3a08775
λ³΄μ•ˆ: Pydantic μŠ€ν‚€λ§ˆμ˜ μ œμ–΄ 문자 μ£Όμž… 취약점 μˆ˜μ • (μ •κ·œμ‹ μΆ”κ°€)
seonghobae Aug 8, 2026
bf84e88
λ³΄μ•ˆ: ConnectionCreateIn.dsn ν•„λ“œμ— μ œμ–΄ 문자 μ£Όμž… 방지 μ •κ·œμ‹ μΆ”κ°€
seonghobae Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions backend/app/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class ConnectionCreateIn(BaseModel):
min_length=1,
max_length=4096,
description=("PostgreSQL or Snowflake connection string. Not logged."),
pattern=r"^[^\x00-\x1F\x7F]+$",
)


Expand All @@ -77,6 +78,7 @@ class ApplySqlIn(BaseModel):
"Conservative PostgreSQL DDL subset with unquoted snake_case "
"identifiers. Arbitrary SQL is rejected."
),
pattern=r"^[^\x00-\x08\x0B\x0C\x0E-\x1F\x7F]+$",
)
# Default to a rolled-back pre-flight; the caller must opt in to persist.
dry_run: bool = True
Expand Down Expand Up @@ -190,7 +192,7 @@ class IndexRedundancyOut(BaseModel):
class DiagramViewCreateIn(BaseModel):
"""Request body for saving an ERD canvas view."""

name: str = Field(min_length=1, max_length=200)
name: str = Field(min_length=1, max_length=200, pattern=r"^[^\x00-\x1F\x7F]+$")
# Opaque client layout (node positions, hidden tables, viewport). The API
# bounds the serialized size in the endpoint to prevent abuse.
layout_json: dict
Expand All @@ -214,9 +216,9 @@ class DiagramViewDetailOut(DiagramViewOut):
class TableAnnotationUpsertIn(BaseModel):
"""Request body for creating/updating a table annotation."""

schema_name: str = Field(min_length=1, max_length=255)
relation_name: str = Field(min_length=1, max_length=255)
body: str = Field(min_length=1, max_length=10_000)
schema_name: str = Field(min_length=1, max_length=255, pattern=r"^[^\x00-\x1F\x7F]+$")
relation_name: str = Field(min_length=1, max_length=255, pattern=r"^[^\x00-\x1F\x7F]+$")
body: str = Field(min_length=1, max_length=10_000, pattern=r"^[^\x00-\x08\x0B\x0C\x0E-\x1F\x7F]+$")


class TableAnnotationOut(BaseModel):
Expand Down Expand Up @@ -285,7 +287,7 @@ class NamingLintOut(BaseModel):
class DbmlConvertIn(BaseModel):
"""Request body for converting DBML text into a snapshot."""

dbml: str = Field(min_length=1, max_length=524_288)
dbml: str = Field(min_length=1, max_length=524_288, pattern=r"^[^\x00-\x08\x0B\x0C\x0E-\x1F\x7F]+$")
include_ddl: bool = True
dialect: Literal["postgresql", "snowflake"] = "postgresql"

Expand All @@ -302,7 +304,7 @@ class DbmlConvertOut(BaseModel):
class ApiKeyCreateIn(BaseModel):
"""Request body for creating an API key."""

key_name: str = Field(min_length=1, max_length=128)
key_name: str = Field(min_length=1, max_length=128, pattern=r"^[^\x00-\x1F\x7F]+$")


class ApiKeyOut(BaseModel):
Expand Down
Loading