o.c.o.converter: hard-code width of converted updown button#1493
Merged
berryma4 merged 1 commit intoDec 3, 2015
Merged
Conversation
When converting an updown button into a spinner, only the buttons are relevant. Hard-coding the width shows only the buttons.
berryma4
added a commit
that referenced
this pull request
Dec 3, 2015
o.c.o.converter: hard-code width of converted updown button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting an updown button into a spinner, only the buttons
are relevant. Hard-coding the width shows only the buttons.
An alternative option is to give the spinner widget the option not to show the readback, which we may do if everyone is happy with that change.
See #1494.