Skip to content

Save&Restore search on "Description/Comment" seems to be case sensitive#3371

Merged
georgweiss merged 2 commits into
ControlSystemStudio:masterfrom
jasonbrudvikess:CSSTUDIO-3105
May 7, 2025
Merged

Save&Restore search on "Description/Comment" seems to be case sensitive#3371
georgweiss merged 2 commits into
ControlSystemStudio:masterfrom
jasonbrudvikess:CSSTUDIO-3105

Conversation

@jasonbrudvikess

@jasonbrudvikess jasonbrudvikess commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

It seems there were several issues connected to searching on the "Description/Comment" and "Node Name" fields.

For the "Description/Comment" field:

  • Searches containing upper case letters failed, even if the decription being looked for had upper case letters and matched
  • Searches with lower case letters succeeded
  • Searches for sub-words failed
  • Searches containing multiple words failed

While for the "Node Name" field there was no case sensitivity issue, but it had the following issues in common with the "Description/Comment" field:

  • Searches for sub-words failed
  • Searches containing multiple words failed

This branch fixes those issues.

Perhaps I have been overly verbose with my logging output - that can be reduced.

@jasonbrudvikess jasonbrudvikess changed the title Save&Restore search on "Description/Comment" and "Node Name" seem to be case sensitive Save&Restore search on "Description/Comment" seems to be case sensitive Apr 17, 2025

@georgweiss georgweiss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is client-side changes only. My preference would be to update search implementation on service side.

I will propose an alternative in a f2f meeting.

@jasonbrudvikess

Copy link
Copy Markdown
Collaborator Author

This is client-side changes only. My preference would be to update search implementation on service side.

I will propose an alternative in a f2f meeting.

Ok, that sounds fine.

@shroffk

shroffk commented Apr 17, 2025

Copy link
Copy Markdown
Member

I agree with Georg, that we should make the searches case insensitive on the server side.

Thanks for the work @jasonbrudvikess

@georgweiss georgweiss merged commit c0abdb0 into ControlSystemStudio:master May 7, 2025
@shroffk

shroffk commented May 7, 2025

Copy link
Copy Markdown
Member

I thought we were going to add this feature to the service.
I will create an Issue ticket.

@georgweiss

Copy link
Copy Markdown
Collaborator

@shroffk, the client side changes were reverted, it's all on the service side.

@shroffk

shroffk commented May 7, 2025

Copy link
Copy Markdown
Member

Yes I just noticed that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants