Test different usage of the sequence and ticket numbers.

[dzmitryhil]

Description

Test different usage of the sequence and ticket numbers.
If you use the used ticket, passed sequence, or future sequence the TX won't be accepted.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[miladz68]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

[ysv]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

[wojtek-coreum]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil)

---

integration-tests/xrpl/rpc_test.go line 504 at r1 (raw file):

	signer1 := chains.XRPL.Multisign(t, &createTicketsTx, signer1Acc)

	createTicketsTx = buildCreateTicketsTxForMultiSigning(ctx, t, chains.XRPL, ticketsToCreate, 0, nil, multisigAcc)

what's the purpose of calling the same function second time with same arguments?

---

integration-tests/xrpl/rpc_test.go line 505 at r1 (raw file):

	createTicketsTx = buildCreateTicketsTxForMultiSigning(ctx, t, chains.XRPL, ticketsToCreate, 0, nil, multisigAcc)
	require.NoError(t, rippledata.SetSigners(&createTicketsTx, []rippledata.Signer{

Here, you create a slice just to "deslice" it immediately

---

integration-tests/xrpl/rpc_test.go line 521 at r1 (raw file):

	signer1 = chains.XRPL.Multisign(t, &createTicketsTx, signer1Acc)

	createTicketsTx = buildCreateTicketsTxForMultiSigning(ctx, t, chains.XRPL, ticketsToCreate, 0, usedTicket, multisigAcc)

same here

---

integration-tests/xrpl/rpc_test.go line 545 at r1 (raw file):

	createTicketsTx = buildCreateTicketsTxForMultiSigning(ctx, t, chains.XRPL, ticketsToCreate, *seqNo, nil, multisigAcc)
	signer1 = chains.XRPL.Multisign(t, &createTicketsTx, signer1Acc)
	createTicketsTx = buildCreateTicketsTxForMultiSigning(ctx, t, chains.XRPL, ticketsToCreate, *seqNo, nil, multisigAcc)

... and here

[dzmitryhil]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @wojtek-coreum)

---

integration-tests/xrpl/rpc_test.go line 504 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

what's the purpose of calling the same function second time with same arguments?

The lib we use mutates the original createTicketsTx, but we need it's original state every time.

---

integration-tests/xrpl/rpc_test.go line 505 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Here, you create a slice just to "deslice" it immediately

Right, updated.

---

integration-tests/xrpl/rpc_test.go line 521 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

same here

Updated

---

integration-tests/xrpl/rpc_test.go line 545 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

... and here

Updated

[wojtek-coreum]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil)

[miladz68]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil)