Skip to content

Contract: tests for coreum commission fees and burn rates#72

Merged
keyleu merged 2 commits intomasterfrom
keyne/coreum-commission-fees-and-burn-rates
Dec 22, 2023
Merged

Contract: tests for coreum commission fees and burn rates#72
keyleu merged 2 commits intomasterfrom
keyne/coreum-commission-fees-and-burn-rates

Conversation

@keyleu
Copy link
Collaborator

@keyleu keyleu commented Dec 20, 2023

Description

  • Add test for token with commission fee and burn rate to confirm that everything works out of the box

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@keyleu keyleu requested a review from a team as a code owner December 20, 2023 12:56
@keyleu keyleu requested review from dzmitryhil, miladz68, wojtek-coreum and ysv and removed request for a team December 20, 2023 12:56
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @wojtek-coreum)

@keyleu keyleu merged commit 6f01742 into master Dec 22, 2023
@keyleu keyleu deleted the keyne/coreum-commission-fees-and-burn-rates branch January 10, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants