Skip to content

fixed integration tests for manual refund#80

Merged
miladz68 merged 2 commits intokeyne/update-to-manual-recover-claimfrom
milad/manual-refund-test-fix
Jan 3, 2024
Merged

fixed integration tests for manual refund#80
miladz68 merged 2 commits intokeyne/update-to-manual-recover-claimfrom
milad/manual-refund-test-fix

Conversation

@miladz68
Copy link
Contributor

@miladz68 miladz68 commented Jan 3, 2024

Description

This PR fixes the integration tests for manual recover refunds, so they will pass.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner January 3, 2024 09:35
@miladz68 miladz68 requested review from dzmitryhil, wojtek-coreum and ysv and removed request for a team January 3, 2024 09:35
Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)


relayer/coreum/contract.go line 42 at r1 (raw file):

	ExecUpdateXRPLToken               ExecMethod = "update_xrpl_token"
	ExecUpdateCoreumToken             ExecMethod = "update_coreum_token"
	ExecClaimRefunds                  ExecMethod = "claim_refunds"

This was renamed to claim_refund


relayer/coreum/contract.go line 290 at r1 (raw file):

type claimRefundsRequest struct {
	PendingOperationID string `json:"pending_operation_id"`

Renamed this to pending_refund_id

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @keyleu, @wojtek-coreum, and @ysv)


relayer/coreum/contract.go line 42 at r1 (raw file):

Previously, keyleu (Keyne) wrote…

This was renamed to claim_refund

Done.


relayer/coreum/contract.go line 290 at r1 (raw file):

Previously, keyleu (Keyne) wrote…

Renamed this to pending_refund_id

Done.

Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

@miladz68 miladz68 merged commit b326255 into keyne/update-to-manual-recover-claim Jan 3, 2024
@miladz68 miladz68 deleted the milad/manual-refund-test-fix branch January 3, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants