Add weighted operations run simulation by GNaD13 · Pull Request #1055 · CosmWasm/wasmd

GNaD13 · 2022-10-19T14:31:58Z

Close #797

add operations run simulation for

update admin
migrate contract
clear admin

add new test contract for simulation migrate contract

…erations

alpe

Very nice as well!
Only minor changes or discussion needed. Thanks a lot! 💐

Please check https://app.circleci.com/pipelines/github/CosmWasm/wasmd/2626/workflows/efb2ba60-30d9-4345-969f-841400c67cf4/jobs/9529?invite=true#step-102-56

alpe · 2022-11-01T09:47:49Z

x/wasm/simulation/operations.go

+
+		msg := types.MsgUpdateAdmin{
+			Sender:   simAccount.Address.String(),
+			NewAdmin: simtypes.RandomAccounts(r, 1)[0].Address.String(),


Let's use simtypes.RandomAcc(r, accs) instead to not run dry

I have fixed

alpe · 2022-11-01T09:48:15Z

x/wasm/simulation/operations.go

 		msg := types.MsgInstantiateContract{
 			Sender: simAccount.Address.String(),
-			Admin:  simtypes.RandomAccounts(r, 1)[0].Address.String(),
+			Admin:  adminAccount.Address.String(),


alpe · 2022-11-01T09:49:26Z

app/params/weights.go

-	DefaultWeightMsgInstantiateContract int = 100
+
+	DefaultWeightMsgStoreCode           int = 100
+	DefaultWeightMsgInstantiateContract int = 50


Why flipping store and instantiate weights?

I have fixed

alpe · 2022-11-01T09:50:24Z

app/params/weights.go

+	DefaultWeightMsgStoreCode           int = 100
+	DefaultWeightMsgInstantiateContract int = 50
 	DefaultWeightMsgExecuteContract     int = 100
+	DefaultWeightMsgUpdateAdmin         int = 100


I would expect this to happen quire rarely. How about 25?

I have changed

alpe · 2022-11-01T09:50:57Z

app/params/weights.go

+	DefaultWeightMsgInstantiateContract int = 50
 	DefaultWeightMsgExecuteContract     int = 100
+	DefaultWeightMsgUpdateAdmin         int = 100
+	DefaultWeightMsgClearAdmin          int = 100


I would expect this to happen quire rarely. How about 10?

I have changed

alpe · 2022-11-01T09:51:24Z

app/params/weights.go

 	DefaultWeightMsgExecuteContract     int = 100
+	DefaultWeightMsgUpdateAdmin         int = 100
+	DefaultWeightMsgClearAdmin          int = 100
+	DefaultWeightMsgMigrateContract     int = 100


I would expect more instantiations than migrations. How about 50?

I have changed

alpe · 2022-11-01T09:52:51Z

x/wasm/simulation/operations.go

+			txCtx.SimAccount.PrivKey,
+		)
+		if err != nil {
+			return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate mock tx"), nil, err


Suggested change

return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate mock tx"), nil, err

return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate tx"), nil, err

I have changed

alpe · 2022-11-01T09:53:21Z

x/wasm/simulation/operations.go

+			return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to read response data"), nil, err
+		}
+
+		fmt.Printf("%v\n", result.Data[0].MsgType)


Let's avoid Printfs

I have removed

alpe · 2022-11-01T10:00:29Z

x/wasm/simulation/operations.go

+
+		var wasmBz []byte
+		var err error
+		wasmBz, err = os.ReadFile("./../x/wasm/keeper/testdata/reflect_1_1.wasm")


I tried to avoid hard coding any contracts here. See L106-7.
As we only store reflect contracts you can just pick a different code id and drop the store code part.

I have fixed to embed

codecov · 2022-11-01T13:54:37Z

Codecov Report

Merging #1055 (5697af6) into main (84e24d3) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   59.28%   59.19%   -0.09%     
==========================================
  Files          53       53              
  Lines        6722     6732      +10     
==========================================
  Hits         3985     3985              
- Misses       2442     2452      +10     
  Partials      295      295

Impacted Files	Coverage Δ
x/wasm/module.go	`37.90% <0.00%> (ø)`
x/wasm/types/proposal.go	`61.31% <0.00%> (-1.81%)`	⬇️

alpe · 2022-11-01T17:42:17Z

Let's remove some code to finish this: see 5697af6

GNaD13 · 2022-11-02T03:34:07Z

Let's remove some code to finish this: see 5697af6

Got it :3 tysm!!!

alpe

Great contribution! 🏄

* add WeightedOperations msg update admin * add check contract info condition * add fnc simulate migrate * add weights operations migrate contract * fix simulation msg update admin * add simulation.NewWeightedOperation * add sml msg clear admin * fix lint * remove msg migrate * change admin to use test account * add migrate * add new contract for simulation migrate * correct return log * Polish SimulateMsgMigrateContract Co-authored-by: Alex Peters <alpe@users.noreply.github.com>

GNaD13 added 7 commits October 18, 2022 20:02

add WeightedOperations msg update admin

3e95f06

add check contract info condition

d85aba3

add fnc simulate migrate

ad6fb0c

add weights operations migrate contract

e1cc173

fix simulation msg update admin

929d6e1

add simulation.NewWeightedOperation

8b67948

add sml msg clear admin

0479146

GNaD13 requested a review from alpe as a code owner October 19, 2022 14:31

fix lint

1d6b3fc

GNaD13 marked this pull request as draft October 19, 2022 15:00

remove msg migrate

8bf8f4f

GNaD13 marked this pull request as ready for review October 23, 2022 17:20

GNaD13 added 4 commits October 24, 2022 01:25

change admin to use test account

9162023

add migrate

1ee28be

add new contract for simulation migrate

e2ed481

correct return log

8b7d1f9

GNaD13 mentioned this pull request Oct 27, 2022

fix: Simulation is not deterministic due to GenSignedMockTx cosmos/cosmos-sdk#12374

Merged

19 tasks

Merge remote-tracking branch 'cosmwasm/main' into dang/add-WeightedOp…

25872b2

…erations

alpe reviewed Nov 1, 2022

View reviewed changes

alpe changed the title ~~add weighted operations run simulation~~ Add weighted operations run simulation Nov 1, 2022

fix some minor

68631da

Polish SimulateMsgMigrateContract

5697af6

mergify bot mentioned this pull request Nov 2, 2022

[DO NOT MERGE] 1055 feedback #1071

Closed

alpe approved these changes Nov 2, 2022

View reviewed changes

alpe merged commit bfb4bc0 into CosmWasm:main Nov 2, 2022

	return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate mock tx"), nil, err
	return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate tx"), nil, err

Conversation

GNaD13 commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alpe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alpe commented Nov 1, 2022

Uh oh!

GNaD13 commented Nov 2, 2022

Uh oh!

alpe left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GNaD13 commented Oct 19, 2022 •

edited

Loading

alpe left a comment •

edited

Loading

codecov bot commented Nov 1, 2022 •

edited

Loading