chore: prepare for new Cosmos Stack Release Family#2446
chore: prepare for new Cosmos Stack Release Family#2446aljo242 wants to merge 35 commits intoCosmWasm:mainfrom
Conversation
- make format (gofumpt, misspell, gci) - ibc tests and wasm handler updates Made-with: Cursor
Replace local path with commit hash for cross-repo dependency. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
pinosu
left a comment
pinosu
left a comment
There was a problem hiding this comment.
Nice work! LGTM 👍
I added some minor comments, and after those are fixed I will do another final review.
app/app.go
Outdated
| func (app *WasmApp) RegisterNodeService(clientCtx client.Context, cfg config.Config) { | ||
| nodeservice.RegisterNodeService(clientCtx, app.GRPCQueryRouter(), cfg) | ||
| nodeservice.RegisterNodeService(clientCtx, app.GRPCQueryRouter(), cfg, func() int64 { | ||
| return app.CommitMultiStore().LatestVersion() // todo fix |
| appConfig.Telemetry.PrometheusRetentionTime = 60 | ||
| appConfig.Telemetry.EnableHostnameLabel = false | ||
| appConfig.Telemetry.GlobalLabels = [][]string{{"chain_id", args.chainID}} | ||
| appConfig.Telemetry.Enabled = true // nolint:staticcheck // TODO update to OTEL |
There was a problem hiding this comment.
good point. We can migrate to otel in another PR 👍
tests/e2e/ibc_callbacks_test.go
Outdated
| if spec.expAck { | ||
| // and the packet is relayed | ||
| wasmibctesting.RelayAndAckPendingPackets(path) | ||
| _ = wasmibctesting.RelayAndAckPendingPackets(path) |
There was a problem hiding this comment.
in all the methods that return an error we should assert NoError instead of ignoring it. WDYT?
chore: use context to validate authority
|
Hey @pinosu, would you be able to review the newest changes? They contain the latest SDK API changes and the use of |
Hey, definitely. On Monday as soon as I'm back I will review this 👍 |
| } | ||
|
|
||
| func TestUpdateParamsAuthority(t *testing.T) { | ||
| wasmApp := app.Setup(t) |
There was a problem hiding this comment.
I think these tests could be set up as table driven tests. WDYT?
|
Hey @vladjdk , I added just a comment to the tests, to use if possible the table driven approach. |
bump sdk and ibc tags to latest rcs
fix pr comments upstream
|
Hey @pinosu, I applied the fixes to your review, and also bumped all the dependencies to RCs before we launch. |
4 participants
No description provided.