Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

fix timepicker and timezone#28

Merged
labananala merged 3 commits into
masterfrom
hanna/T69248775-timepicker
Jul 17, 2020
Merged

fix timepicker and timezone#28
labananala merged 3 commits into
masterfrom
hanna/T69248775-timepicker

Conversation

@labananala
Copy link
Copy Markdown
Contributor

@labananala labananala commented Jul 17, 2020

T69248775

  • fixed: timepicker had wonky behavior
    • to test:
      • in index.html, go to "Timepicking", or any of the other ones with a timepicker
      • try typing in a time into the timepicker and make sure it behaves as expected
  • fixed: setting dates in the input box changed the time if timezone was different from user's
    • to test:
      • in index.html, go to "Datepicker with timezone"
      • try typing in a date in the input box and make sure the time doesn't change

@labananala labananala requested a review from georgemayer July 17, 2020 14:10
georgemayer
georgemayer approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgemayer georgemayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels great, nice work.

@labananala labananala merged commit b3912bb into master Jul 17, 2020
@labananala labananala deleted the hanna/T69248775-timepicker branch July 17, 2020 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@georgemayer georgemayer georgemayer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Deployable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labananala @georgemayer