Translation/update#972
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new Arabic resource file with ~392 strings and plurals, extends Spanish and Ukrainian string resources with new UI labels, adds one Simplified Chinese string and a rename there, and removes a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/res/values-ar/strings.xml`:
- Around line 97-98: The Arabic strings.xml accidentally overwrote the numeric
"count" resource with crash-export text; remove the <string name="count"> entry
so R.string.count falls back to the default "%1$d / %2$d" used by
getString(R.string.count, progress.current, progress.total) in UiExtensions.kt
(calls at 448 and 508), leaving the correct crash_export_backup_failed string
intact.
In `@app/src/main/res/values-es/strings.xml`:
- Line 266: The Spanish string resource note_text_too_long_truncated contains a
typo ("trucando"); update the value to use the correct word "truncado" while
preserving the placeholder (%1$d) and surrounding punctuation so the final
string becomes "Texto demasiado largo, truncado a %1$d caracteres"; locate and
edit the string with the name note_text_too_long_truncated to make this change.
In `@app/src/main/res/values-zh-rCN/strings.xml`:
- Line 123: The localized strings file is missing the resource key
delete_reminder_question which RemindersActivity.confirmDeletion() still
references; add a new string entry named delete_reminder_question to
values-zh-rCN/strings.xml (matching the Chinese translation used for the
existing delete_reminder or the appropriate localized phrasing) so
R.string.delete_reminder_question resolves for zh-rCN and stops falling back to
the default locale.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 143c6ba6-92e3-411a-b487-d164f3f6fe87
⛔ Files ignored due to path filters (1)
app/translations.xlsxis excluded by!**/*.xlsx
📒 Files selected for processing (4)
app/src/main/res/values-ar/strings.xmlapp/src/main/res/values-es/strings.xmlapp/src/main/res/values-uk/strings.xmlapp/src/main/res/values-zh-rCN/strings.xml
Closes #967
Closes #952
Closes #937
Closes #932
Summary by CodeRabbit