Skip to content

Translation/update#972

Merged
Crustack merged 6 commits into
mainfrom
translation/update
Apr 12, 2026
Merged

Translation/update#972
Crustack merged 6 commits into
mainfrom
translation/update

Conversation

@Crustack
Copy link
Copy Markdown
Owner

@Crustack Crustack commented Apr 12, 2026

Closes #967
Closes #952
Closes #937
Closes #932

Summary by CodeRabbit

  • Localization
    • Added comprehensive Arabic translations (392 new strings and plurals) for core UI, notes, backups, security, and pluralized messages
    • Enhanced Spanish, Ukrainian and Simplified Chinese translations with additional UI labels and messages
    • Standardized reminder wording across locales for consistent user-facing prompts

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 62fd84cb-500e-4a34-80c5-376ba50d02fa

📥 Commits

Reviewing files that changed from the base of the PR and between ddab08d and c4989d9.

⛔ Files ignored due to path filters (1)
  • app/translations.xlsx is excluded by !**/*.xlsx
📒 Files selected for processing (5)
  • app/src/main/res/values-ar/strings.xml
  • app/src/main/res/values-es/strings.xml
  • app/src/main/res/values-uk/strings.xml
  • app/src/main/res/values-zh-rCN/strings.xml
  • app/src/main/res/values/strings.xml
💤 Files with no reviewable changes (1)
  • app/src/main/res/values/strings.xml
✅ Files skipped from review due to trivial changes (3)
  • app/src/main/res/values-es/strings.xml
  • app/src/main/res/values-ar/strings.xml
  • app/src/main/res/values-uk/strings.xml
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/src/main/res/values-zh-rCN/strings.xml

📝 Walkthrough

Walkthrough

Adds a new Arabic resource file with ~392 strings and plurals, extends Spanish and Ukrainian string resources with new UI labels, adds one Simplified Chinese string and a rename there, and removes a delete_reminder string from the default (values) resources.

Changes

Cohort / File(s) Summary
Arabic Localization (New)
app/src/main/res/values-ar/strings.xml
New ~392 Arabic <string> and multiple <plurals> entries covering core note actions, backup/export/import, security/biometric prompts, labels/folders/reminders, errors/crash reporting, and quantity-dependent messages (e.g., duplicates, exported_notes, notes_too_big_truncating).
Spanish Updates
app/src/main/res/values-es/strings.xml
Added ~37 Spanish strings and plurals for backup/cleanup flows, automatic backup behavior, migration progress, sorting/navigation options, color defaults, truncation/oversize warnings (notes_too_big_truncating) and duplicates plural.
Ukrainian Updates
app/src/main/res/values-uk/strings.xml
Added ~15 Ukrainian strings for auto-sort, date-format-in-note-view, color default hints/actions, view-mode options, day/month labels, swap action, and text-size preview.
Simplified Chinese Updates
app/src/main/res/values-zh-rCN/strings.xml
Added date_format_apply_in_note_view and renamed delete_reminder_questiondelete_reminder in this locale.
Default (base) strings
app/src/main/res/values/strings.xml
Removed delete_reminder from the base values resources (leaving existing delete_reminder_question).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I hopped through XML rows and keys,

Arabic blossoms with graceful ease,
Spanish, Ukrainian, Chinese too—
Strings aligned in every hue,
A tiny hop for code and me 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The changes include an unexpected string resource removal (delete_reminder) in the base strings.xml file, which goes beyond the scope of adding/updating translations for the four linked localization issues. Clarify whether the removal of 'delete_reminder' from the base strings.xml is intentional and necessary for the localization updates, or if it should be retained to maintain consistency with the localized versions.
Title check ❓ Inconclusive The title 'Translation/update' is vague and generic, using non-descriptive language that does not convey meaningful information about the specific changes made to the codebase. Use a more specific and descriptive title that identifies the primary changes, such as 'Add Arabic translations and update Spanish, Ukrainian, and Chinese localization strings' to better summarize the scope of changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The pull request successfully addresses all four linked translation issues (#967, #952, #937, #932) by adding or updating localization strings in Arabic, Spanish, Ukrainian, and Simplified Chinese resource files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch translation/update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/res/values-ar/strings.xml`:
- Around line 97-98: The Arabic strings.xml accidentally overwrote the numeric
"count" resource with crash-export text; remove the <string name="count"> entry
so R.string.count falls back to the default "%1$d / %2$d" used by
getString(R.string.count, progress.current, progress.total) in UiExtensions.kt
(calls at 448 and 508), leaving the correct crash_export_backup_failed string
intact.

In `@app/src/main/res/values-es/strings.xml`:
- Line 266: The Spanish string resource note_text_too_long_truncated contains a
typo ("trucando"); update the value to use the correct word "truncado" while
preserving the placeholder (%1$d) and surrounding punctuation so the final
string becomes "Texto demasiado largo, truncado a %1$d caracteres"; locate and
edit the string with the name note_text_too_long_truncated to make this change.

In `@app/src/main/res/values-zh-rCN/strings.xml`:
- Line 123: The localized strings file is missing the resource key
delete_reminder_question which RemindersActivity.confirmDeletion() still
references; add a new string entry named delete_reminder_question to
values-zh-rCN/strings.xml (matching the Chinese translation used for the
existing delete_reminder or the appropriate localized phrasing) so
R.string.delete_reminder_question resolves for zh-rCN and stops falling back to
the default locale.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 143c6ba6-92e3-411a-b487-d164f3f6fe87

📥 Commits

Reviewing files that changed from the base of the PR and between 795db70 and ddab08d.

⛔ Files ignored due to path filters (1)
  • app/translations.xlsx is excluded by !**/*.xlsx
📒 Files selected for processing (4)
  • app/src/main/res/values-ar/strings.xml
  • app/src/main/res/values-es/strings.xml
  • app/src/main/res/values-uk/strings.xml
  • app/src/main/res/values-zh-rCN/strings.xml

Comment thread app/src/main/res/values-ar/strings.xml Outdated
Comment thread app/src/main/res/values-es/strings.xml Outdated
Comment thread app/src/main/res/values-zh-rCN/strings.xml Outdated
@Crustack Crustack merged commit 1f83cc1 into main Apr 12, 2026
1 check passed
@Crustack Crustack deleted the translation/update branch April 12, 2026 11:40
@coderabbitai coderabbitai Bot mentioned this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arabic translations update ES translations update Ukrainian translation update Simplified Chinese translations update

1 participant