docs(openapi): declare POST /v1/timeentry 201 envelope shape (#326)#327
Merged
Merged
Conversation
Parallel to #316 (customer POST envelope fix). The timeentry POST 201 had a description and the `Idempotency-Replay` header declaration but NO content schema at all — strictly worse than the customer case before #316, where the body was at least declared (wrongly) as a bare entity. SDK code-gen here couldn't reach the row inside the envelope from generated client types because the body shape was completely unspecified. The controller emits `{message, timeEntry}`. Pin that envelope in the spec and add a corresponding test in `tests/api/openapi.test.js` so a regression on either side fails CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326.
Summary
Parallel to #316 (customer POST). The timeentry POST 201 had no content schema at all. Declare the
{message, timeEntry}envelope and pin with a test.Test plan
npm run lint && npm test— 783 passing (was 782).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/