test(customerpayment): cover non-finite cpayAmount rejection (#346)#347
Merged
Conversation
The `cpayAmountField` zod schema applies `.coerce.number().finite()` — JSON has no literal for Infinity, but `coerce` happily turns the string "Infinity" into the float, and a DOUBLE column would store it and poison every downstream sum / aging-bucket calculation. The existing "accepts negative cpayAmount" test had a comment claiming the schema "blocks 0 and the infinities" but only the zero case had an explicit test; the .finite() branch was unpinned. Add POST + PATCH cases covering Infinity and -Infinity. Mirrors the existing invoicejob.test.js coverage for the same scenario on `injbAmount`. Test count: 790 → 792. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #346.
Summary
Adds POST + PATCH cases for the .finite() rejection on
cpayAmount. Mirrors the existing invoicejob.test.js coverage forinjbAmount.Test plan
npm run lint && npm test— 792 passing (was 790).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/