docs(openapi): declare GET/PATCH/DELETE /v1/timeentry/{id} envelopes (#358)#359
Merged
Merged
Conversation
…nvelopes The single-row time-entry endpoints had only `description: ...` on their 200 responses — same missing-content-schema pattern fixed for the customer single GET (#312), POST (#316), bulk (#332), bycompany list (#340), and timeentry POST (#326) + bycompany list (#348). Without the declaration, SDK code-gen treated the response body as untyped. Pin all three operations on this path: - GET → {message, timeEntry} - PATCH → {message, timeEntry} - DELETE → {message, id} (no entity body; the row was archived, the controller echoes the int teId so the client can confirm what got soft-deleted) Add a sweep test in tests/api/openapi.test.js covering all three. The DELETE assertion also pins the absence of a `timeEntry` field so a future "echo the row back on delete" refactor would surface as a test failure. Test count: 794 → 795. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #358.
Summary
Declares the three operation 200 envelopes: GET/PATCH emit
{message, timeEntry}; DELETE emits{message, id}. Sweep test pins each.Test plan
npm run lint && npm test— 795 passing (was 794).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/