test(openapi): pin GET /v1/customer/search 200 envelope (#360)#361
Merged
Merged
Conversation
The OpenAPI spec already declares the full envelope for the search
endpoint — {message, q, companyId, count, limit, offset, customers:
Customer[]} — but no test asserted the shape. A future "cleanup"
that dropped a field from the spec would silently regress SDK
code-gen output without CI catching it.
Pin all seven properties + the Customer items \$ref so the contract
stays stable. Test count: 795 → 796.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #360.
Summary
Pins the seven-property envelope already declared in the spec so a future spec edit that drops a field surfaces in CI.
Test plan
npm run lint && npm test— 796 passing (was 795).Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/