Only use qUtf8Printable for Qt versions >= 5.4,#12
Merged
jrbarron merged 1 commit intoCutehacks:masterfrom Jan 3, 2017
Merged
Conversation
Collaborator
|
@micuintus I don't think it is worth it to have the version check there. I suggest we use a qPrintable() all the time just to avoid making the code messier here. If you update the pull request, I can merge it in. |
Contributor
Author
|
@jrbarron I'll update the PR this evening once I am back on my own computer. |
(qUtf8Printable was first added in version 5.4 of Qt). Fixes Cutehacks#11
micuintus
force-pushed
the
bugs/Issue11_gel_not_compiling
branch
from
dc70e51 to
0d39ca9
Compare
Contributor
Author
|
(Updated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as this function was first added in this version of Qt.
Use qPrintable for smaller Qt versions.
Fixes #11