Skip to content

Add support for slin16 packets#28

Merged
Ulexus merged 1 commit into
CyCoreSystems:masterfrom
SvenKube:master
Oct 17, 2025
Merged

Add support for slin16 packets#28
Ulexus merged 1 commit into
CyCoreSystems:masterfrom
SvenKube:master

Conversation

@SvenKube
Copy link
Copy Markdown
Contributor

@SvenKube SvenKube commented Oct 1, 2025

This PR add support for the slin16 audiosocket message kind added to asterisk in asterisk/asterisk#1492

@SvenKube
Copy link
Copy Markdown
Contributor Author

SvenKube commented Oct 1, 2025

I would keep this as a draft until the PR in the Asterisk repo has been merged.

@Ulexus
Copy link
Copy Markdown
Member

Ulexus commented Oct 1, 2025 •
edited
Loading

FWIW, Asterisk's current implementation does not adhere to the 0x10 = slin (16-bit, 8kHz) spec. It sends that for all codecs... which is rather irritating, but they chose to re-interpret 0x10 to be general "audio" as opposed to audio of a particular codec.

I'm not at all averse to adding more types here for more codecs, but unless/until Asterisk actually adheres to such a spec, I'm afraid it will not be of much use. I guess we can see how your PR to Asterisk plays out.

Ulexus
Ulexus approved these changes Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; should wait until the upstream actually merges, but I appreciate the effort on both sides.

@SvenKube SvenKube marked this pull request as ready for review October 17, 2025 13:08
@SvenKube
Copy link
Copy Markdown
Contributor Author

SvenKube commented Oct 17, 2025

The asterisk PR has been merged without any more changes.

@Ulexus Ulexus merged commit 78f916d into CyCoreSystems:master Oct 17, 2025
@Ulexus
Copy link
Copy Markdown
Member

Ulexus commented Oct 17, 2025

Great news. Thanks!

@Ulexus Ulexus mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ulexus Ulexus Ulexus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SvenKube @Ulexus