Skip to content

fix: add missing Vulnerability comparator for sorting#246

Merged
jkowalleck merged 1 commit intoCycloneDX:mainfrom
RodneyRichardson:add-vulnerability-sort
Jun 10, 2022
Merged

fix: add missing Vulnerability comparator for sorting#246
jkowalleck merged 1 commit intoCycloneDX:mainfrom
RodneyRichardson:add-vulnerability-sort

Conversation

@RodneyRichardson
Copy link
Contributor

Partial fix for #245.

This should work when credits is not set.

Partial fix for CycloneDX#245.

Signed-off-by: Rodney Richardson <rodney.richardson@cambridgeconsultants.com>
Copy link
Contributor

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

self.assertIsNone(v.analysis)
self.assertFalse(v.affects)

def test_sort(self) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkowalleck jkowalleck changed the title Make Vulnerability sortable fix: add missing Vulnerability comparator for sorting Jun 10, 2022
@jkowalleck jkowalleck merged commit c3f3d0d into CycloneDX:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants