fix: prevent errors on metadata handling for some specification versions#330
Merged
jkowalleck merged 1 commit intomainfrom Jan 6, 2023
Merged
fix: prevent errors on metadata handling for some specification versions#330jkowalleck merged 1 commit intomainfrom
jkowalleck merged 1 commit intomainfrom
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
fix-specification-specifics-json
branch
from
460af02 to
dc36e27
Compare
jkowalleck
commented
Jan 6, 2023
| bom_json = self._recurse_specialise_component(bom_json) | ||
|
|
||
| if not self.bom_metadata_supports_tools(): | ||
| del bom_json['metadata']['tools'] |
Member
Author
There was a problem hiding this comment.
this was a delete without checking if bom_json['metadata'] existed in the first place ...
especially when it was just deleted 3 lines before
jkowalleck
changed the title
jkowalleck
changed the title
Member
Author
|
@madpah FYI this one needs a forward-port to the next major version |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.