chore(deps): update poetry and other dependency versions#369
Merged
madpah merged 3 commits intoCycloneDX:mainfrom Mar 31, 2023
Merged
chore(deps): update poetry and other dependency versions#369madpah merged 3 commits intoCycloneDX:mainfrom
madpah merged 3 commits intoCycloneDX:mainfrom
Conversation
Member
|
partially duplicates #358 |
Contributor
Author
|
@jkowalleck didn't see that PR 🙈 I can wait till it is merged and then recreate my with the type hint changes. |
Collaborator
jkowalleck
requested changes
Mar 30, 2023
Member
jkowalleck
left a comment
jkowalleck
left a comment
There was a problem hiding this comment.
Could you rebase and incorporate my remarks?
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Signed-off-by: gruebel <anton.gruebel@gmail.com>
gruebel
force-pushed
the
update-packageurl-dep
branch
from
2154bdc to
fe68787
Compare
Contributor
Author
|
@jkowalleck I lower bound |
Member
|
you need to upgrade the lowest-lockfile too, thanks in advance |
Signed-off-by: gruebel <anton.gruebel@gmail.com>
jkowalleck
approved these changes
Mar 31, 2023
Member
|
LGTM, @madpah |
madpah
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I juste wanted to update
packageurlwith the added type hints to remove the type ignores, I also found a typing issue incyclonedx/serialization/__init__.pybut I couldn't upgrade thepoertry.lockfile, so I had to use the latest 1.4.1 version and they changed the lock file version to 2.0, which looks now different. This probably also the reason, why all the dependabot PRs are failing 🤔