fix: properly sort components based on all properties#599
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
after this one is releaed, the release 7.3.1 SHOULD be yanked, as it introduced bugs |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
@madpah please review |
|
Code looks good @jkowalleck - but some tests failing to run - seems to be GitHub related?? |
|
|
Looks to be related to GitHub having changed the version of MacOSX associated with Previously this pointed to: Now it points to: And the new runner image only has support for Python 3.11 & 3.12 - see here for macos-14-arm64 compared with here for macos-12 |
…which only has support for Python 3.11 and Python 3.12 Signed-off-by: Paul Horton <paul.horton@owasp.org>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
|
CI running for MacOSX now @jkowalleck - but Codacy has an alert |
|
@madpah thank you so much for the macOS CI fix. 🥇 |
reverts #587 - as this one introduced errors
fixes #598
fixes #586