Skip to content

FIX: update Conda package parsing to handle build containing underscore#66

Merged
madpah merged 2 commits intomainfrom
fix/issue-65-conda-package-parsing
Nov 15, 2021
Merged

FIX: update Conda package parsing to handle build containing underscore#66
madpah merged 2 commits intomainfrom
fix/issue-65-conda-package-parsing

Conversation

@madpah
Copy link
Collaborator

@madpah madpah commented Nov 10, 2021

Hopefully, this is the solution to the issue raised in #44, #51 and refined into #65.

@bollwyvl kindly provided an example Conda package URL that was breaking our parsing. This PR aims to make our parsing more robust and cater for the example provided.

Signed-off-by: Paul Horton phorton@sonatype.com

…core

Signed-off-by: Paul Horton <phorton@sonatype.com>
@madpah madpah requested a review from a team as a code owner November 10, 2021 14:27
@madpah madpah requested a review from jkowalleck November 10, 2021 14:27
@madpah madpah added bug Something isn't working enhancement New feature or request labels Nov 10, 2021
@madpah madpah linked an issue Nov 10, 2021 that may be closed by this pull request
Signed-off-by: Paul Horton <phorton@sonatype.com>
@bollwyvl
Copy link

Great, thanks for pushing this forward.

A reasonably exhaustive test would be to verify the parsing against a snapshot of the various conda.anaconds.org/{repo}/{subdir}/repodata.json (for {conda-forge,anaconda} and {noarch,win-64,linux-64,osx-64}) which would have examples of every badly-behaved filename that are still installable, and an oracle of their correct parsed values (if even possible).

@madpah
Copy link
Collaborator Author

madpah commented Nov 10, 2021

Thanks @bollwyvl - great idea - will look into that!

@bollwyvl
Copy link

Meanwhile: would the upstream index even know how to handle multiple namespaces? sonatype/ossindex-public#27

@madpah madpah merged commit 2c6020a into main Nov 15, 2021
@madpah madpah deleted the fix/issue-65-conda-package-parsing branch December 22, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conda Package parsing brittle when build contains an underscore

3 participants