FIX: update Conda package parsing to handle build containing underscore#66
Merged
FIX: update Conda package parsing to handle build containing underscore#66
build containing underscore#66Conversation
…core Signed-off-by: Paul Horton <phorton@sonatype.com>
Signed-off-by: Paul Horton <phorton@sonatype.com>
|
Great, thanks for pushing this forward. A reasonably exhaustive test would be to verify the parsing against a snapshot of the various |
Collaborator
Author
|
Thanks @bollwyvl - great idea - will look into that! |
|
Meanwhile: would the upstream index even know how to handle multiple namespaces? sonatype/ossindex-public#27 |
jkowalleck
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this is the solution to the issue raised in #44, #51 and refined into #65.
@bollwyvl kindly provided an example Conda package URL that was breaking our parsing. This PR aims to make our parsing more robust and cater for the example provided.
Signed-off-by: Paul Horton phorton@sonatype.com