feat: HashType.from_composite_str for Blake2b, SHA3, Blake3#663
Merged
jkowalleck merged 3 commits intoCycloneDX:mainfrom Aug 14, 2024
Merged
feat: HashType.from_composite_str for Blake2b, SHA3, Blake3#663jkowalleck merged 3 commits intoCycloneDX:mainfrom
HashType.from_composite_str for Blake2b, SHA3, Blake3#663jkowalleck merged 3 commits intoCycloneDX:mainfrom
Conversation
Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>
jkowalleck
changed the title
HashType.from_composite_str for Blake2b, SHA3, Blake3
jkowalleck
requested changes
Aug 14, 2024
Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>
jkowalleck
changed the title
HashType.from_composite_str for Blake2b, SHA3, Blake3HashType.from_composite_str for Blake2b, SHA3, Blake3
jkowalleck
added
enhancement
jkowalleck
approved these changes
Aug 14, 2024
Member
jkowalleck
left a comment
jkowalleck
left a comment
There was a problem hiding this comment.
thanks for the contribution, @schlenk
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code mistreated hashes for Blake2b and SHA3.
Code for explicitly handling SHA1 & BLAKE3 was added, as those have no variants defined in the CycloneDX specification.
fixes #652