fix/df-973: Handles invalid unicode in email fields#363
Open
jbarnsley10 wants to merge 4 commits intomainfrom
Open
fix/df-973: Handles invalid unicode in email fields#363jbarnsley10 wants to merge 4 commits intomainfrom
jbarnsley10 wants to merge 4 commits intomainfrom
Conversation
…orms-engine-plugin into fix/df-973-unicode-email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Shows a validation error if an email address is entered that contains invalid (unicode) characters. A specific error message is shown (rather than the generic 'wrong format') so a user can determine that for example the type of dash is incorrect.
This PR will need a model bump of defra/forms-model once the designer PR has been merged DEFRA/forms-designer#1378
Jira ticket: DF-973DF-973
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).