Skip to content

fix(DF-922): remove legacy version metadata fallback from adapter for…#364

Open
mokhld wants to merge 2 commits intomainfrom
fix/df-922-remove-version-metadata-fallback
Open

fix(DF-922): remove legacy version metadata fallback from adapter for…#364
mokhld wants to merge 2 commits intomainfrom
fix/df-922-remove-version-metadata-fallback

Conversation

@mokhld
Copy link
Copy Markdown
Contributor

@mokhld mokhld commented Apr 13, 2026

…matter

Proposed change

Remove getVersionMetadata and the formMetadata.versions fallback path that was producing fabricated versionNumber values for pre-versioning forms. Version metadata now resolves solely from $$__formVersion embedded in the form definition by the manager.

Also removes the now-dead submittedVersionNumber from FormContext and versionNumber from `FormModel, which only existed to feed the deleted fallback.

Jira ticket: https://eaflood.atlassian.net/browse/DF-972?atlOrigin=eyJpIjoiYTA1N2NhNjFlZWE1NDA0NDg0YzNhNjdkNTIzMzViOWEiLCJwIjoiaiJ9

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

mokhld added 2 commits April 13, 2026 17:51
…matter

Remove getVersionMetadata and the formMetadata.versions fallback path
that was producing fabricated versionNumber values for pre-versioning
forms. Version metadata now resolves solely from $$__formVersion
embedded in the form definition by the manager.

Also removes the now-dead submittedVersionNumber from FormContext and
versionNumber from FormModel, which only existed to feed the deleted
fallback.
@mokhld mokhld marked this pull request as ready for review April 13, 2026 17:23
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant