fix(DF-922): remove legacy version metadata fallback from adapter for…#364
Open
fix(DF-922): remove legacy version metadata fallback from adapter for…#364
Conversation
…matter Remove getVersionMetadata and the formMetadata.versions fallback path that was producing fabricated versionNumber values for pre-versioning forms. Version metadata now resolves solely from $$__formVersion embedded in the form definition by the manager. Also removes the now-dead submittedVersionNumber from FormContext and versionNumber from FormModel, which only existed to feed the deleted fallback.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…matter
Proposed change
Remove
getVersionMetadataand theformMetadata.versionsfallback path that was producing fabricatedversionNumbervalues for pre-versioning forms. Version metadata now resolves solely from$$__formVersionembedded in the form definition by the manager.Also removes the now-dead
submittedVersionNumberfromFormContextandversionNumberfrom `FormModel, which only existed to feed the deleted fallback.Jira ticket: https://eaflood.atlassian.net/browse/DF-972?atlOrigin=eyJpIjoiYTA1N2NhNjFlZWE1NDA0NDg0YzNhNjdkNTIzMzViOWEiLCJwIjoiaiJ9
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).