Skip to content

Ensured that esri Layers are beneath the draw layer #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markfee merged 2 commits into from
Aug 4, 2026
Merged

Ensured that esri Layers are beneath the draw layer #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94064d
Ensured that esri Layers are beneath the draw layer
markfee Aug 4, 2026
5359379
Fixed ghost issue when editing esri polygons to intersect
markfee Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/beta/draw-es/src/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function attachEvents ({ pluginState, mapProvider, events, eventBus, butt

// Prevent self-intersect
// TODO - refactor this when rings and/or multipolygons are supported
if (toolInfoType === 'reshape') {
if (toolInfoType === 'reshape-stop') {
const isSimple = simplifyOperator.isSimple(graphic.geometry) && graphic.geometry.rings.length === 1
if (!isSimple) {
sketchViewModel.undo()
Expand Down
13 changes: 13 additions & 0 deletions plugins/datasets/src/adapters/esri/esriLayerAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,21 @@ export default class EsriLayerAdapter extends LayerAdapter {

// Finally show all layers that are visible based on the dataset/mapStyle visibility
await Promise.all(topLevelDatasets.map(registryDataset => this.applyDatasetVisibility(registryDataset.id)))
this._reorderLayers()
this.resolveReady()
}

_reorderLayers () {
// Ensure that all sketch layers are on top of the map, so that they are not obscured by other layers
// Only applicable when the draw plugin is in use, but safe to call regardless
const layersLength = this._map?.allLayers?.items?.length
if (layersLength) {
this._map.allLayers.items
.filter((layer) => layer.id.includes('ketchLayer'))
.forEach((layer) => this._map.reorder(layer, layersLength))
}
}

_addGroupLayer (esriGroupId) {
// Either adds a new group layer to the map, or returns an existing one if it already exists
if (!this._groupLayers[esriGroupId]) {
Expand Down Expand Up @@ -117,6 +129,7 @@ export default class EsriLayerAdapter extends LayerAdapter {
await this._addLayers(registryDataset)
const { parentId } = registryDataset
const vectorTileLayer = this._mapVisibilityLayers[parentId || datasetId]
this._reorderLayers()
this.applyDatasetOpacity(datasetId)
this._applyStyleLayerPaintProperties(registryDataset, vectorTileLayer)
this.applyDatasetVisibility(datasetId)
Expand Down
Loading