Skip to content

Modify code to prepare HTTPS migration#3800

Closed
louisjdmartin wants to merge 7 commits into
DIRACGrid:integrationfrom
louisjdmartin:pr_to_dirac
Closed

Modify code to prepare HTTPS migration#3800
louisjdmartin wants to merge 7 commits into
DIRACGrid:integrationfrom
louisjdmartin:pr_to_dirac

Conversation

@louisjdmartin

@louisjdmartin louisjdmartin commented Aug 17, 2018

Copy link
Copy Markdown
Contributor

Following the last meeting here some change that can already be done in DIRAC for HTTPS migration.

It also include a whoami method for services.

BEGINRELEASENOTES

*CS
CHANGE: Separation between threads an logic in Refresher
CHANGE: Separation between threads an logic in ServiceInterface
NEW: Client for Configuration/Server

*Core
NEW: adding new way to detect url in Core.Base.Client (using a kwargs)
NEW: a simple whoami for services

ENDRELEASENOTES

@coveralls

coveralls commented Aug 17, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.009%) to 20.685% when pulling 6f8b416 on louisjdmartin:pr_to_dirac into d7aa596 on DIRACGrid:integration.

Placeholder client to speak with ConfigurationServer.
"""

pass

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using here

self.setServer('Configuration/Server')

wouldn't work?

@louisjdmartin louisjdmartin Aug 20, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometime component need to provide an explicit url (for example, the master configuration server choose a slave server to ping it). This line may override the url given from **kwargs with a random url from CS.
But I can add this:

  def __init__(self, **kwargs):
    if 'url' not in kwargs:
      kwargs['url'] = 'Configuration/Server'
    super(ConfigurationServerClient, self).__init__(**kwargs)

So by default it use an URL from the CS, but it still possible to give another URL on the keywords arguments.

@fstagni

fstagni commented Aug 20, 2018

Copy link
Copy Markdown
Contributor

The release notes should mention which DIRAC system is involved.

@louisjdmartin louisjdmartin force-pushed the pr_to_dirac branch 2 times, most recently from 4199422 to 6f8b416 Compare August 23, 2018 08:16
@atsareg

atsareg commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

This PR should be dropped as replcaed by #3815, shouldn't it ?

@chaen

chaen commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Yes :)

@fstagni fstagni closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants