[v7r0] Make M2Crypto TLS implementation compatible with openssl 1.1 serie#4391
Merged
Merged
Conversation
chaen
force-pushed
the
rel-v7r0_NEW_m2cryptoSSL1.1
branch
from
4f5dce1 to
61048c9
Compare
Contributor
|
Looks like your MR got merged. Do you want to take this out of [WIP]? |
Contributor
Author
|
Actually no, I am making a new MR for M2Crypto which would change slightly the interface |
Contributor
|
Just to say: your MR for M2Crypto is not passing all the tests on their repo. And, any progress on that in general? |
Contributor
Author
|
Ah, I guess it's another of this mess with the "required"/"non required" mess. I'll rebase. |
chaen
force-pushed
the
rel-v7r0_NEW_m2cryptoSSL1.1
branch
from
61048c9 to
8311957
Compare
Merged
Member
|
Can this be unmarked as WIP now? |
Contributor
Author
|
Yeah... let me add an extra comment, and ping the m2crypto guys again, and then yes |
Contributor
Author
|
Actually I changed my mind, and close the MR on m2Crypto, so we can use it as is. I remove the WIP |
chaen
changed the title
chrisburr
approved these changes
Aug 28, 2020
fstagni
approved these changes
Sep 8, 2020
atsareg
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use M2Crypto API instead of environment variable to accept proxy certificate. This is compatible with
the openssl 1.0 serie
Although the code can cope with the API not being exposed, I'd rather wait to have https://gitlab.com/m2crypto/m2crypto/merge_requests/236 merged to be sure that it is in its final form
New MR to watch for: https://gitlab.com/m2crypto/m2crypto/merge_requests/238
BEGINRELEASENOTES
*Core
NEW: Make M2Crypto TLS implementation compatible with openssl 1.1 serie
ENDRELEASENOTES