[v7r0] Minor fixes + doc on Bdii#4520
Merged
Merged
Conversation
andresailer
reviewed
Apr 1, 2020
| single state | ||
| """ | ||
| def __str__( self ): | ||
|
|
Contributor
There was a problem hiding this comment.
Some of these changes cause merge conflicts when getting merged to v7r1
Co-Authored-By: Andre Sailer <andre.philippe.sailer@cern.ch>
Contributor
|
Please also add the ConfigTemplate include for these 2 agents. |
Contributor
Author
|
Done. @andresailer did you have something else in mind? |
andresailer
reviewed
Apr 2, 2020
andresailer
left a comment
andresailer
left a comment
Contributor
There was a problem hiding this comment.
The Glue2 configuration is a bit of a mess:
If Glue2Only is false:
- Look at entries in Host for Glue1 information
- Look at entries in GLUE2URLs for Glue2 information
If Glue2Only is True:
Look at Host for Glue2 information
Co-Authored-By: Andre Sailer <andre.philippe.sailer@cern.ch>
atsareg
approved these changes
Apr 2, 2020
Contributor
|
This was merged despite having failing integration tests. Was it on purpose ? |
Contributor
Author
|
The reason why this was merged is because the only failing test is (https://github.com/DIRACGrid/DIRAC/pull/4520/checks?check_run_id=554903754) which has nothing to do with the changes here (there's a failing ElasticSearch test -- seems like githubActions or docker failure). |
Closed
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*RSS
FIX: correct verbosity (avoid non-necessary warnings)
*docs
NEW: Minimal documentation on Bdii2CSAgent and GOCDB2CSAgent
ENDRELEASENOTES