[v7r0] transformation scripts command line parsing, Components with underscores#4656
Merged
Conversation
The previous split would drop things after an underscore in the installed components name (e.g., Bdii2CSAgent_GLUE2)
allows calling the script with e.g., -ddd
atsareg
approved these changes
Jun 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComponentInstaller: allow underscores in installed components
The previous split would drop things after an underscore in the installed components name (e.g., Bdii2CSAgent_GLUE2), this leads to bad displays and log file displaying in the webapp SystemAdministrator. (Show Errors -> Show Log fails to find log file)
I am not sure if this change affects anyone negatively? Maybe somewhere something other then SystemName_ComponentName would be in the startup directory, where superfluous characters need to be dropped, or they should be ignored?
BEGINRELEASENOTES
*Framework
FIX: ComponentInstaller did not allow having underscores in the IntanceNames affecting the WebApp SystemAdministrator log file display via show errors -> show log
*TS
FIX: fix parsing of command line flags (e.g., -ddd) for dirac-transformation-archive/clean/remove-output/verify-outputdata
ENDRELEASENOTES