Skip to content

[v7r0] Add extraOptions only when the executable is a DIRAC script#4836

Merged
atsareg merged 1 commit into
DIRACGrid:rel-v7r0from
fstagni:v7r0-fixes66
Jan 6, 2021
Merged

[v7r0] Add extraOptions only when the executable is a DIRAC script#4836
atsareg merged 1 commit into
DIRACGrid:rel-v7r0from
fstagni:v7r0-fixes66

Conversation

@fstagni

@fstagni fstagni commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

*WMS
CHANGE: JobWrapper: Add extraOptions only when the executable is a DIRAC script

ENDRELEASENOTES

@sfayer

sfayer commented Nov 20, 2020

Copy link
Copy Markdown
Member

This looks like a good approach to me and should fix our issue... I'm a little dubious about adding the --cfg at that specific point in-case someone wanted to include an extra option that isn't a config (although I don't think I've ever actually seen that used for anything else).

Regards,
Simon

@fstagni

fstagni commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

Thanks Simon. Regarding your remark: theoretically, it's possible to include an extra option that is not a DIRAC cfg file, but practically speaking that would not happen. I anyway added one more check.

@fstagni fstagni marked this pull request as ready for review November 23, 2020 10:02
@fstagni fstagni requested a review from atsareg as a code owner November 23, 2020 10:02
@fstagni fstagni changed the title [WIP][v7r0] Add extraOptions only when the executable is a DIRAC script [v7r0] Add extraOptions only when the executable is a DIRAC script Nov 23, 2020
@atsareg

atsareg commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

I do not see how this PR fixes the problem. The "ExtraOption" is added to the job's executable arguments in the JobAgent. In the JobWrapper you can not change this. This ExtraOptions option is quite confusing and needs some extra discussion/clarification

@fstagni

fstagni commented Nov 25, 2020

Copy link
Copy Markdown
Contributor Author

I close this one now. I will look into providing a different fix using DIRACSYSCONFIG, and I will re-open if I see issues.

@fstagni

fstagni commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

Re-opened after DIRACGrid/Pilot#122

@atsareg atsareg merged commit 8802cb1 into DIRACGrid:rel-v7r0 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants