[v7r0] Add extraOptions only when the executable is a DIRAC script#4836
Conversation
|
This looks like a good approach to me and should fix our issue... I'm a little dubious about adding the --cfg at that specific point in-case someone wanted to include an extra option that isn't a config (although I don't think I've ever actually seen that used for anything else). Regards, |
60d2821 to
f94c95b
Compare
|
Thanks Simon. Regarding your remark: theoretically, it's possible to include an extra option that is not a DIRAC cfg file, but practically speaking that would not happen. I anyway added one more check. |
|
I do not see how this PR fixes the problem. The "ExtraOption" is added to the job's executable arguments in the JobAgent. In the JobWrapper you can not change this. This ExtraOptions option is quite confusing and needs some extra discussion/clarification |
|
I close this one now. I will look into providing a different fix using |
|
Re-opened after DIRACGrid/Pilot#122 |
BEGINRELEASENOTES
*WMS
CHANGE: JobWrapper: Add extraOptions only when the executable is a DIRAC script
ENDRELEASENOTES