Skip to content

[v7r2] renames of column names to avoid reserved keywords#4956

Merged
atsareg merged 4 commits into
DIRACGrid:integrationfrom
fstagni:v7r2-fixes26
Mar 3, 2021
Merged

[v7r2] renames of column names to avoid reserved keywords#4956
atsareg merged 4 commits into
DIRACGrid:integrationfrom
fstagni:v7r2-fixes26

Conversation

@fstagni

@fstagni fstagni commented Feb 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

*Core
FIX: use logging.warning in favor of deprecated logging.warn

*Framework
CHANGE: renames of column names to avoid reserved keywords

ENDRELEASENOTES

chrisburr
chrisburr previously approved these changes Feb 9, 2021
View reviewed changes
@TaykYoku

TaykYoku commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

@fstagni I submitted a #4958 PR today, that already contains some changes to this PR:

src/DIRAC/ConfigurationSystem/scripts/dirac_admin_add_site.py 
src/DIRAC/ConfigurationSystem/scripts/dirac_admin_sort_cs_sites.py 
src/DIRAC/ConfigurationSystem/scripts/dirac_configuration_dump_local_cache.py 
src/DIRAC/Core/scripts/dirac_agent.py 
src/DIRAC/Core/scripts/dirac_executor.py 
src/DIRAC/Core/scripts/dirac_install_extension.py 
src/DIRAC/Core/scripts/dirac_service.py

@fstagni

fstagni commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

Yes I saw that, and also started going through it. We can merge yours quickly and then I can rebase this small one of mine.

@atsareg

atsareg commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

Please resolve conflicts due to thee merged #4958

@fstagni fstagni changed the title [v7r2] Fixes for propagating changes from scripts of v7r1 [v7r2] renames of column names to avoid reserved keywords Feb 16, 2021
@fstagni fstagni force-pushed the v7r2-fixes26 branch 4 times, most recently from 975c49b to 8813e69 Compare February 16, 2021 17:19
@andresailer

andresailer commented Feb 17, 2021

Copy link
Copy Markdown
Contributor

The changed column names need to be mentioned here https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-v7r2 right?

andresailer
andresailer previously approved these changes Feb 17, 2021
View reviewed changes
@fstagni

fstagni commented Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

The changed column names need to be mentioned here https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-v7r2 right?

Yes, done.

atsareg
atsareg reviewed Feb 24, 2021
View reviewed changes
Comment thread src/DIRAC/Core/scripts/install_full.cfg Outdated
@fstagni
Update src/DIRAC/Core/scripts/install_full.cfg
3af859c 
Co-authored-by: Andrei Tsaregorodtsev <atsareg@diracgrid.org>
@atsareg atsareg merged commit 6d9c712 into DIRACGrid:integration Mar 3, 2021
chaen
chaen reviewed Mar 9, 2021
View reviewed changes
Comment thread src/DIRAC/FrameworkSystem/Client/ComponentInstaller.py
{}, True)
result = self.monitoringClient.getInstallations(
{'UnInstallationTime': None},
{'System': system, 'DIRACModule': installation['Component']['Module']},

@chaen chaen Mar 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fstagni should it be DIRACSystem here ?

@fstagni fstagni Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in my open PR.

@fstagni fstagni mentioned this pull request Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atsareg atsareg atsareg left review comments
@chaen chaen chaen left review comments
@andresailer andresailer andresailer approved these changes
@chrisburr chrisburr chrisburr left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fstagni @TaykYoku @atsareg @andresailer @chaen @chrisburr