[v7r2] Use DIRACOS2 for Python 3 client integration tests#4989
Merged
Conversation
chrisburr
force-pushed
the
py3-install
branch
from
08bd8df to
de6a94c
Compare
chrisburr
force-pushed
the
py3-install
branch
from
de6a94c to
193f0f4
Compare
chrisburr
requested review from
andresailer,
atsareg and
fstagni
as code owners
fstagni
reviewed
Feb 25, 2021
chrisburr
commented
Feb 25, 2021
fstagni
approved these changes
Mar 2, 2021
Member
Author
|
Can we get this one merged so I can rebase #4994? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the two already approved PRs as it will be broken without them: #4980 #4975
The main change here is to use DIRACOS2 and
pip installwhen running the Python 3 client integration tests (up until now the version fromchrisburr/DIRACOS2was being used withdirac-install).The only notable change is that use of
$DIRACROOT/scripts/doesn't really make sense with a Python 3 + pip installation but I think it should be safe to take it from$PATHin all situations. Any thoughts?BEGINRELEASENOTES
*WorkloadManagement
CHANGE: Take dirac-jobexec from PATH by default
*Python 3
NEW: Run Python 3 integration tests with DIRACOS2 and pip install
ENDRELEASENOTES