[int] Fix MySQL logging for statements containing wildcard#8620
Closed
sfayer wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 25, 2026
Member
Author
|
I've looked through the mysqldb library code and mogrify isn't that special: % characters still need to be double escaped... I'll replace this pull request with a much simpler one and stick with the existing log set-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears my SQL log fix-up was too simple: It didn't handle the case where a mysql "%" wildcard was in the expression properly... This patch converts it to the proper MySQL function. This is quite a lot more expensive as it involves using the cursor (i.e. probably a round-trip to the mysql server), I've added a gate so it only does that if the log message is actually going to be used so we don't slow down production running.
BEGINRELEASENOTES
*Core
FIX: Fix MySQL logging for statements containing wildcard
ENDRELEASENOTES