feat: Enable remote pilot logging using HTTP interface to Tornado.#158
Merged
fstagni merged 3 commits intoNov 8, 2022
Merged
Conversation
8dd0a87 to
f91f303
Compare
46a832b to
9160b6e
Compare
c1118b6 to
11bef91
Compare
fstagni
reviewed
Sep 2, 2022
c95956e to
3b6bf8a
Compare
Contributor
Author
|
OK,
But this is for Dirac, not Pilot repo.
Actually, the line length is the problem, clearly
Cheers, JM
p.s why can’t I see your comments on GitHub ?
… On 6 Sep 2022, at 16:03, Andre Sailer ***@***.***> wrote:
@andresailer commented on this pull request.
In Pilot/pilotCommands.py <#158 (comment)>:
> + self.cfg.append(
+ "-o /DIRAC/Security/CertFile=%s/hostcert.pem" % self.pp.certsLocation
+ )
+ self.cfg.append(
+ "-o /DIRAC/Security/KeyFile=%s/hostkey.pem" % self.pp.certsLocation
+ )
we have two settings in DIRAC's pyproject toml for black
https://github.com/DIRACGrid/DIRAC/blob/df213a5c3c21c71390e7066ee8cf8ea501ac5943/pyproject.toml#L11-L13 <https://github.com/DIRACGrid/DIRAC/blob/df213a5c3c21c71390e7066ee8cf8ea501ac5943/pyproject.toml#L11-L13>
—
Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2KE7IPBOCSO7UWRSETCHTV45FJ7ANCNFSM5YG7GS6Q>.
You are receiving this because you authored the thread.
|
7661f05 to
3d788a8
Compare
Contributor
|
I am not against merging this PR (see also DIRACGrid/DIRAC#6208 (comment)). But maybe you want to re-check it and add something else? |
Contributor
Author
|
I think we could go ahead and merge to in order to be able to test the DIRAC part. If we find something broken I can always create a new PR. |
fstagni
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A"wrapper" approach to remote pilot logging. Logging is happening in parallel to stdout and to a
string.iobuffer which is flushed when its size exceeds a predefined value. The buffer is periodically sent to Tornado server. The logs are handled by a plugin, aFileCachePluginstores log files in Tornado web area. They can be pulled by an agent and stored on a SE.