Skip to content

[POC]: Use DIRAC new CI to use legacy adaptor#589

Merged
chaen merged 2 commits into
DIRACGrid:mainfrom
Robin-Van-de-Merghel:robin-improve-ci
Aug 4, 2025
Merged

[POC]: Use DIRAC new CI to use legacy adaptor#589
chaen merged 2 commits into
DIRACGrid:mainfrom
Robin-Van-de-Merghel:robin-improve-ci

Conversation

@Robin-Van-de-Merghel

Copy link
Copy Markdown
Contributor

@Robin-Van-de-Merghel

Copy link
Copy Markdown
Contributor Author

Note that, in the CI, we can see which services were adapted:

Screenshot 2025-07-09 at 15 28 31

This data is taken from the CS at /DiracX/LegacyClientEnabled cf https://codimd.web.cern.ch/s/fJ9ofi8SJ

@aldbr

aldbr commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

I think it's expected, only the JobStateUpdate is expected to be covered by DiracX at this point.

@Robin-Van-de-Merghel

Copy link
Copy Markdown
Contributor Author

I think it's expected, only the JobStateUpdate is expected to be covered by DiracX at this point.

If that's so, I can remove the monitoring from this PR so that it works.

@Robin-Van-de-Merghel

Copy link
Copy Markdown
Contributor Author

Another error not caught from DIRAC CI: https://github.com/DIRACGrid/diracx/actions/runs/16187805198/job/45696702356?pr=589#step:11:378

With TQDB

@Robin-Van-de-Merghel Robin-Van-de-Merghel changed the title feat: Use DIRAC new CI to use legacy adaptor [POC]: Use DIRAC new CI to use legacy adaptor Jul 16, 2025
@Robin-Van-de-Merghel Robin-Van-de-Merghel force-pushed the robin-improve-ci branch 2 times, most recently from 6d6e830 to 017ef10 Compare July 28, 2025 14:41
@Robin-Van-de-Merghel

Copy link
Copy Markdown
Contributor Author

To be fixed before merge*

if [ -f pilot-tests-failed ]; then has_error=1; echo "Pilot tests failed"; fi
if [ ${has_error} = 1 ]; then exit 1; fi
- name: diracx logs
if: ${{ failure() }}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woudn't be nice to has logs to prove that diracx has been used? (docker logs, and filter to remove .well-known requests)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a bad idea. You could just grep the logs and count the number of calls per router

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few propositions:

  1. We also show errors (internal errors logs, with the full stack)
    1.1 Separate in two steps: one for the endpoint summary, one for the errors
    1.2 Summary then errors in the same step
  2. We only show the summary

Both ways, I have this result. Is it how you've imagined it? :

   1 DELETE /api/pilots/?pilot_stamps=anotherPilot&delete_only_aborted=false 403
   1 DELETE /api/pilots/?pilot_stamps=aPilot&delete_only_aborted=false 403
   1 GET /api/auth/legacy-exchange?preferred_username=ciuser&scope=vo%3AJenkins+group%3Ajenkins_fcadmin+property%3ANormalUser+property%3AFileCatalogManagement&expires_minutes=1440&s
ource=ProxyManager 200
   1 GET /api/auth/legacy-exchange?preferred_username=pilot&scope=vo%3Avo+group%3Apilot+property%3ALimitedDelegation+property%3AGenericPilot&expires_minutes=1440&source=ProxyManager
 200
   1 PATCH /api/jobs/heartbeat 200
   1 PATCH /api/jobs/status?force=true 200
   1 POST /api/auth/token 200
   1 POST /api/pilots/ 403
   2 DELETE /api/pilots/?pilot_stamps=anotherPilot&delete_only_aborted=false 400
   2 DELETE /api/pilots/?pilot_stamps=aPilot&delete_only_aborted=false 400
  ...
   3 PATCH /api/jobs/metadata 204
   4 GET /api/auth/legacy-exchange?preferred_username=ciuser&scope=vo%3Avo+group%3Aprod+property%3ANormalUser+property%3AFileCatalogManagement+property%3ACSAdministrator+property%3A
ProductionManagement+property%3AFullDelegation+property%3AJobAdministrator+property%3ASiteManager+property%3AServiceAdministrator+property%3AProxyManagement+property%3AOperator&expi
res_minutes=1440&source=ProxyManager 200
   5 PATCH /api/jobs/status?force=false 200
   8 POST /api/pilots/ 500

(Filtered by endpoint, method, and code)

@Robin-Van-de-Merghel Robin-Van-de-Merghel marked this pull request as ready for review August 4, 2025 11:04
@chaen chaen merged commit 903e67d into DIRACGrid:main Aug 4, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants