Skip to content

Type hint for DataFrame #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thodson-usgs merged 2 commits into from
Jun 6, 2023
Merged

Type hint for DataFrame #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8afc77
Add DataFrame type annotation
davetapley Jun 1, 2023
05b30e6
Update dataretrieval/nwis.py
davetapley Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dataretrieval/nwis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
WATERDATA_SERVICES = ['qwdata', 'measurements', 'peaks', 'pmcodes', 'water_use', 'ratings']


def format_response(df, service=None, **kwargs):
def format_response(df: pd.DataFrame, service=None, **kwargs) -> pd.DataFrame:
"""Setup index for response from query.

This function formats the response from the NWIS web services, in
Expand Down Expand Up @@ -79,7 +79,7 @@ def format_response(df, service=None, **kwargs):
return df.sort_index()


def preformat_peaks_response(df):
def preformat_peaks_response(df: pd.DataFrame):
"""Datetime formatting for the 'peaks' service response.

Function to format the datetime column of the 'peaks' service response.
Expand Down