Expand site info metadata (addresses #73)#74
Merged
thodson-usgs merged 3 commits intoDec 23, 2022
Conversation
thodson-usgs
approved these changes
Dec 23, 2022
| if alias in parameters: | ||
| md.site_info = lambda: what_sites(sites=parameters[alias]) | ||
| break | ||
| # site_no is preferred over sites to set site_info if both are present, |
Collaborator
There was a problem hiding this comment.
This part feels a little kludgy, but I'd have to think more about how we improve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #73 and fixes bug with
countyCdqueries.Specifically the following changes are proposed:
query_waterservices) to be called with only thecountyCdbeing specified, previously this was not allowed and made it impossible? to do a county query. Alters error message to match expanded behavior._set_metadatafunction to allow thelambdafunction assigned to thesite_infoattribute of the metadata object to be set by parameters other than onlysitesandsite_no_set_metadatafunctionality that do not execute any queries but check that thelambdafunctions behindmetadata.site_infoare set upsite_infoinwaterservices_test.pyas thesite_infoattribute can now be set by more parameters