replaced GUID with IRI#3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c464cf611
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// LOICA 1.0.7 includes pandas-2-compatible assay output and preserves | ||
| /// gene-product HEX colors for downstream tables and plots. Pin the managed | ||
| /// environment so existing installs can be upgraded deterministically. | ||
| const LOICA_REQUIREMENT = "loica==1.0.7"; |
There was a problem hiding this comment.
When a fresh circuit runtime is created, or an existing runtime misses the new marker, ensureCircuitEnv passes this exact requirement through pythonPackagesInstall/uv add. uv add --help says these entries are PEP 508 requirements, but the official PyPI page for loica lists 1.0.6 as the latest release and its release history ends at 1.0.6, so loica==1.0.7 has no candidate and environment setup returns nonzero before any circuit simulation can run.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex I just released LOICA version 1.0.7, can you double check uv and the package point to the latest loica so it would be loica equal or higher than 1.0.7. I will be codeveloping these tools so pulling always the latest loica will help for now and the I will freeze it on release.
There was a problem hiding this comment.
Summary
- Updated the circuit runtime LOICA requirement to
loica>=1.0.7, allowing uv to pull the latest compatible LOICA release while enforcing the requested minimum version. apps/desktop/src/features/circuit/core/circuit-run.tsL20-L29 - Updated the synthetic-biology package setup list to install
loica>=1.0.7instead of pinning exactly1.0.7. apps/desktop/src/features/editor/components/EnvironmentPanel.tsxL30-L37 - Added a minimum-version comparison for the environment installed-state check so LOICA
1.0.7or newer is accepted. apps/desktop/src/features/editor/components/EnvironmentPanel.tsxL50-L89
Testing
- ✅
pnpm --filter @gg/desktop lint - ✅
pnpm --filter @gg/desktop build
Committed changes on the current branch with commit 92d4d27 and created a PR titled “Allow LOICA 1.0.7 or newer.”
| "numpy", | ||
| "pandas", | ||
| "matplotlib", | ||
| "loica==1.0.7", |
There was a problem hiding this comment.
The synthetic-biology setup button installs every entry in SYNBIO_PACKAGES via the same uv add path, so workspaces that click “Set up synthetic biology project” now fail on the nonexistent loica==1.0.7 candidate; PyPI currently publishes loica only through 1.0.6, which also means the new exact-version installed check below can never become true from a normal PyPI install.
Useful? React with 👍 / 👎.
|
This looks good but lets move the data storage to the gg_data crate so that the storage is consistent with the other ways that we use the SQLite DB for app settings, AI chat history, MCP servers, etc. |
2 participants
No description provided.