Skip to content

Adjust hero neon scan timing and keyframes for a slower single sweep#49

Open
Gonza10V wants to merge 1 commit into
mainfrom
codex/slow-down-programming-animation
Open

Adjust hero neon scan timing and keyframes for a slower single sweep#49
Gonza10V wants to merge 1 commit into
mainfrom
codex/slow-down-programming-animation

Conversation

@Gonza10V

Copy link
Copy Markdown
Contributor

Motivation

  • Improve the neon scan visual by slowing the effect and making a single linear sweep with clearer glow timing.
  • Eliminate the rapid double-pass behavior and better control the drop-shadow pulses for a more polished hero headline effect.

Description

  • Change the .hero-neon-text--active animation from 2.4s var(--ease-out) 2 to 14.4s linear 1 to create one slow, linear pass.
  • Rewrite the @keyframes hero-neon-scan sequence to explicit percentage stops and adjusted background-position values, and add distinct glow intervals to control the drop-shadow intensity.
  • No other layout, colors, or non-animation CSS rules were modified.

Testing

  • No automated tests were added or modified for this CSS-only change.
  • No automated tests were run as part of this change; visual verification in-browser and standard CI static checks are recommended.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28c5d8f838

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/styles/global.css
Comment on lines +998 to 999
50% {
background-position: 120% 0;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the midpoint reset that creates a second sweep

With the new 14.4s ... 1 animation, this 50% keyframe jumps background-position back to 120% immediately after the 49.99% stop set it to -120%, so the headline performs another full sweep from 50% to 100% instead of the intended single slow pass. This preserves the double-pass behavior in a slower form; for one sweep, the animation should progress only once across the full 0–100% duration.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant