Skip to content

Conversation

@Wout-atmire
Copy link
Contributor

@Wout-atmire Wout-atmire commented Jan 5, 2026

References

Related REST PR: DSpace/DSpace#11736

Description

Made CanSubscribeFeature configurable with can-subscribe-feature.enable (true by default).
If can-subscribe-feature.enable is configured to false, then CanSubscribeFeature#isAuthorized will return false.

Instructions for Reviewers

List of changes in this PR:

  • The implementation for CanSubscribeFeature has been modified to make isAuthorized return false when the can-subscribe-feature.enable configuration is configured to false.
  • In dspace.cfg: can-subscribe-feature.enable = true
  • In rest.cfg, expose the can-subscribe-feature.enable configuration to the front-end

Can be tested by configuring can-subscribe-feature.enable = false;
In the UI login, and make sure the "Subscriptions" option is not available in the user-menu.
Also make sure the "Subscribe" option is not available on the Community & Collection pages.

When configuring can-subscribe-feature.enable = true;
In the UI login, and make sure the "Subscriptions" option is available in the user-menu.
Also make sure the "Subscribe" option is available on the Community & Collection pages.

User-menu

image (5)

Community & Collection page

image (6)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added improvement 1 APPROVAL pull request only requires a single approval to merge labels Jan 5, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge improvement

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants