Subscribe feature disable main #4985
Open
+33
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related REST PR: DSpace/DSpace#11736
Description
Made
CanSubscribeFeatureconfigurable withcan-subscribe-feature.enable(true by default).If
can-subscribe-feature.enableis configured to false, thenCanSubscribeFeature#isAuthorizedwill return false.Instructions for Reviewers
List of changes in this PR:
CanSubscribeFeaturehas been modified to makeisAuthorizedreturn false when thecan-subscribe-feature.enableconfiguration is configured to false.dspace.cfg:can-subscribe-feature.enable = truerest.cfg, expose thecan-subscribe-feature.enableconfiguration to the front-endCan be tested by configuring
can-subscribe-feature.enable= false;In the UI login, and make sure the "Subscriptions" option is not available in the user-menu.
Also make sure the "Subscribe" option is not available on the Community & Collection pages.
When configuring
can-subscribe-feature.enable= true;In the UI login, and make sure the "Subscriptions" option is available in the user-menu.
Also make sure the "Subscribe" option is available on the Community & Collection pages.
User-menu
Community & Collection page
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.