-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
area:authAuthentication and access controlAuthentication and access controlarea:backendBackend/server codeBackend/server codearea:networkConnections and client networkingConnections and client networkingarea:securitySecurity-sensitive behaviorSecurity-sensitive behaviorenhancementNew feature or requestNew feature or request
Description
Problem
There is no rate limiting on the passwordless connection approval flow. A malicious client could spam pending connection requests to flood the operator's TUI with approval prompts.
Proposed solution
- Track approval attempt counts per IP address
- After N failed/denied attempts within a window, reject new approval requests from that IP with
auth_error - Simple in-memory tracking is sufficient (resets on server restart)
Suggested defaults
- Max 5 pending/denied attempts per IP per 10 minutes
- Configurable via CLI flags:
--approval-rate-limit <count>and--approval-rate-window <seconds>
Notes
This is especially important for publicly exposed instances where the approval flow is used as the primary access mechanism.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:authAuthentication and access controlAuthentication and access controlarea:backendBackend/server codeBackend/server codearea:networkConnections and client networkingConnections and client networkingarea:securitySecurity-sensitive behaviorSecurity-sensitive behaviorenhancementNew feature or requestNew feature or request