Skip to content

(Pet Frames) Fix Lua error on pet name update in instanced content #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanderBot merged 1 commit into from
May 11, 2026
Merged

(Pet Frames) Fix Lua error on pet name update in instanced content #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Frames/Pets.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,11 +536,15 @@ function DF:UpdatePetName(frame)

local name = GetUnitName(frame.unit, true)
if name then
-- Truncate long names
-- Truncate long names. Use secret-value-safe UTF-8 helpers — GetUnitName
-- can return a secret string in instanced content (delves, encounters).
-- DF:UTF8Len returns 0 for secret values so the truncation branch
-- no-ops, and SetText receives the secret string directly (FontStrings
-- accept secret values; only Lua string ops on them cause errors).
local db = DF:GetFrameDB(frame)
local maxLen = db.petNameMaxLength or 12
if #name > maxLen then
name = name:sub(1, maxLen) .. "..."
if maxLen > 0 and DF:UTF8Len(name) > maxLen then
name = DF:UTF8Sub(name, 1, maxLen) .. "..."
end
frame.nameText:SetText(name)
end
Expand Down