Fix debuff icons persisting on dead frames#85
Merged
DanderBot merged 3 commits intoMay 17, 2026
Conversation
Krathe82
added a commit
to Krathe82/DandersFrames
that referenced
this pull request
May 15, 2026
Add edge-detect flag (dfLastKnownDead) so UpdateAuras_Enhanced is only called once on the dead transition, not on every subsequent UNIT_HEALTH event while the unit remains dead. Clears on the alive branch alongside ResetDeadFade so revival re-arms the flush for the next death.
DanderBot
added a commit
that referenced
this pull request
May 17, 2026
Krathe82
added a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
…on-dead-frames Fix debuff icons persisting on dead frames
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a unit dies, WoW does not fire
UNIT_AURA— so the aura cache retains the pre-death aura list and any debuff icons that were showing before death remain on the dead frame until something else triggers an aura update.Two-part fix:
Features/Auras.luaUpdateAuraIconsDirect: Added a dead/ghost guard at the top of the function. IfUnitIsDeadOrGhost(unit)is true, all aura icons are immediately hidden and the function returns early — same code path as the existing "no cache" quick-out.Frames/Update.luaUpdateHealthFast: Added a call toUpdateAuras_Enhancedin the death path (afterApplyDeadFade), so the new dead guard fires at the moment of death rather than waiting for the next external aura event.Fixes https://danders-lab.netlify.app/bugs/863