Add rabby-wallet-hub job to CircleCI workflow#55
Conversation
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CircleCI configuration to use the rabby-wallet-hub job in the main workflow and makes minor formatting tweaks to the config file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the continuous integration setup by updating the CircleCI configuration. It specifically renames a placeholder job within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The workflow now references a
rabby-wallet-hubjob, but that job is not defined underjobs:in this config, which will cause the workflow to fail; either define it or update the workflow to reference an existing job. - The indentation for
- rabby-wallet-hubunderworkflows -> my-custom-workflow -> jobshas an extra leading space compared to the previous- my-job-nameline and may break YAML parsing; align it with the other job entries. - There is unnecessary trailing whitespace added after the
password: $DOCKER_HUB_PASSWORDline; consider removing it to keep the config clean.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The workflow now references a `rabby-wallet-hub` job, but that job is not defined under `jobs:` in this config, which will cause the workflow to fail; either define it or update the workflow to reference an existing job.
- The indentation for `- rabby-wallet-hub` under `workflows -> my-custom-workflow -> jobs` has an extra leading space compared to the previous `- my-job-name` line and may break YAML parsing; align it with the other job entries.
- There is unnecessary trailing whitespace added after the `password: $DOCKER_HUB_PASSWORD` line; consider removing it to keep the config clean.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request updates the CircleCI workflow to use the rabby-wallet-hub job. However, the configuration is currently invalid because the rabby-wallet-hub job is referenced but not defined within the config.yml file. This will cause the CI pipeline to fail. I've added a critical comment to address this. Please add the job definition to resolve this issue. Once the job is defined, you might also consider removing the now-unused my-job-name job to keep the configuration tidy.
d2c8192
into
dependabot/npm_and_yarn/npm_and_yarn-b83c1950df
* Snyk fix 9b5ecce84e737bc7781a872416e3930c (#38) (#39) * Update 1inch.svg * Snyk fix 9b5ecce84e737bc7781a872416e3930c (#38) * chore(deps): bump h3 from 1.11.1 to 1.15.5 Bumps [h3](https://github.com/h3js/h3) from 1.11.1 to 1.15.5. - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/v1.15.5/CHANGELOG.md) - [Commits](h3js/h3@v1.11.1...v1.15.5) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix: package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8187303 * chore(deps): bump lodash from 4.17.21 to 4.17.23 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump h3 in the npm_and_yarn group across 1 directory Bumps the npm_and_yarn group with 1 update in the / directory: [h3](https://github.com/h3js/h3). Updates `h3` from 1.11.1 to 1.15.5 - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/v1.15.5/CHANGELOG.md) - [Commits](h3js/h3@v1.11.1...v1.15.5) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.5 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> * swap 1inch --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> * Add rabby-wallet-hub job to CircleCI workflow (#55) Code by @gemini-code-assist Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io>
* build: support build pro package. * [WIP] feat: support memory used token in send-token * feat: support drag sort * feat: support dashboard drag sort * ci main (#56) * Snyk fix 9b5ecce84e737bc7781a872416e3930c (#38) (#39) * Update 1inch.svg * Snyk fix 9b5ecce84e737bc7781a872416e3930c (#38) * chore(deps): bump h3 from 1.11.1 to 1.15.5 Bumps [h3](https://github.com/h3js/h3) from 1.11.1 to 1.15.5. - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/v1.15.5/CHANGELOG.md) - [Commits](h3js/h3@v1.11.1...v1.15.5) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix: package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8187303 * chore(deps): bump lodash from 4.17.21 to 4.17.23 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump h3 in the npm_and_yarn group across 1 directory Bumps the npm_and_yarn group with 1 update in the / directory: [h3](https://github.com/h3js/h3). Updates `h3` from 1.11.1 to 1.15.5 - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/v1.15.5/CHANGELOG.md) - [Commits](h3js/h3@v1.11.1...v1.15.5) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.5 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> * swap 1inch --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> * Add rabby-wallet-hub job to CircleCI workflow (#55) Code by @gemini-code-assist Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> * fix: package.json to reduce vulnerabilities (#65) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420 Co-authored-by: snyk-bot <snyk-bot@snyk.io> * fix: package.json to reduce vulnerabilities (#60) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-BABELRUNTIME-10044504 - https://snyk.io/vuln/SNYK-JS-BIGINTBUFFER-3364597 - https://snyk.io/vuln/SNYK-JS-CIPHERBASE-12084814 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-NANOID-8492085 - https://snyk.io/vuln/SNYK-JS-QS-14724253 - https://snyk.io/vuln/SNYK-JS-SHAJS-12089400 - https://snyk.io/vuln/SNYK-JS-SOLANAWEB3JS-6647564 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8187303 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577916 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577917 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577918 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8720086 - https://snyk.io/vuln/SNYK-JS-SECP256K1-8237220 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-WEB3UTILS-6229337 - https://snyk.io/vuln/SNYK-JS-WS-7266574 - https://snyk.io/vuln/SNYK-JS-TMP-11501554 - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8172694 - https://snyk.io/vuln/SNYK-JS-BASEX-10118294 - https://snyk.io/vuln/SNYK-JS-BRACEEXPANSION-9789073 Co-authored-by: snyk-bot <snyk-bot@snyk.io> * Delete .circleci directory (#72) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Potential fix for code scanning alert no. 18: Storage of sensitive information in build artifact Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: richardo2016x <richardo2016x@gmail.com> Co-authored-by: Hodor <lost1q84@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Summary by Sourcery
CI: