Skip to content

Improve type validation without cache#3362

Merged
Supam merged 2 commits intomasterfrom
therve/fix-cache
Mar 31, 2026
Merged

Improve type validation without cache#3362
Supam merged 2 commits intomasterfrom
therve/fix-cache

Conversation

@therve
Copy link
Copy Markdown
Contributor

@therve therve commented Mar 27, 2026

This mostly reverts #2737 which caches instances directly leading to memory issues down the line when big responses are hold in memory. There are still some cases where when we fall back on the previous behavior but it should improve the existing dashboard problem.

Fixes #3029

What does this PR do?

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@therve therve requested review from a team as code owners March 27, 2026 10:21
@therve therve force-pushed the therve/fix-cache branch from 4367180 to 51b467f Compare March 27, 2026 10:26
This mostly reverts #2737 which caches instances directly leading to
memory issues down the line when big responses are hold in memory. There
are still some cases where when we fall back on the previous behavior
but it should improve the existing dashboard problem.

Fixes #3029
@therve therve force-pushed the therve/fix-cache branch from 78af00d to 326bd43 Compare March 27, 2026 10:29
@Supam Supam merged commit 9b5f1c5 into master Mar 31, 2026
20 of 21 checks passed
@Supam Supam deleted the therve/fix-cache branch March 31, 2026 09:30
github-actions bot pushed a commit that referenced this pull request Mar 31, 2026
* Improve type validation without cache

This mostly reverts #2737 which caches instances directly leading to
memory issues down the line when big responses are hold in memory. There
are still some cases where when we fall back on the previous behavior
but it should improve the existing dashboard problem.

Fixes #3029

* Don't shortcut this case. 9b5f1c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory not released after API calls - gc.collect() and close() ineffective

3 participants