Skip to content

Use dd-octo-sts. #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-edmonds-dd merged 3 commits into from
Apr 2, 2026
+20 −30
Merged

Use dd-octo-sts. #3374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bf789b
Use dd-octo-sts.
jack-edmonds-dd Apr 1, 2026
d7921b0
Grant id-token: write to pre-commit reusable workflow call
jack-edmonds-dd Apr 2, 2026
a8be693
Merge branch 'master' into dd-octo-sts/replace-github-app-secrets
jack-edmonds-dd Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions .github/workflows/reusable-pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ on:
required: false
type: boolean
default: true
secrets:
PIPELINE_GITHUB_APP_ID:
required: false
PIPELINE_GITHUB_APP_PRIVATE_KEY:
required: false

env:
GIT_AUTHOR_EMAIL: "packages@datadoghq.com"
Expand All @@ -26,20 +21,23 @@ env:
jobs:
pre-commit:
runs-on: ubuntu-latest
permissions:
id-token: write
contents: read
steps:
- name: Get GitHub App token
id: get_token
- name: Get dd-octo-sts token
id: octo-sts
if: inputs.enable-commit-changes
uses: actions/create-github-app-token@v1
uses: DataDog/dd-octo-sts-action@96a25462dbcb10ebf0bfd6e2ccc917d2ab235b9a # v1.0.4
with:
app-id: ${{ secrets.PIPELINE_GITHUB_APP_ID }}
private-key: ${{ secrets.PIPELINE_GITHUB_APP_PRIVATE_KEY }}
scope: DataDog/datadog-api-client-python
policy: self.github.pre-commit.pull-request
- uses: actions/checkout@v3
with:
fetch-depth: 0
repository: DataDog/datadog-api-client-python
ref: ${{ inputs.target-branch || github.event.pull_request.head.sha || github.ref }}
token: ${{ inputs.enable-commit-changes && steps.get_token.outputs.token || github.token }}
token: ${{ inputs.enable-commit-changes && steps.octo-sts.outputs.token || github.token }}
- uses: actions/setup-python@v4
with:
python-version: '3.11'
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/reusable-python-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ on:
required: false
type: string
default: '[{"platform": "macos-latest", "python-version": "3.8"}, {"platform": "ubuntu-latest", "python-version": "3.8"}, {"platform": "ubuntu-22.04", "python-version": "3.12"}]'
secrets:
PIPELINE_GITHUB_APP_ID:
required: false
PIPELINE_GITHUB_APP_PRIVATE_KEY:
required: false

jobs:
test:
Expand Down
25 changes: 11 additions & 14 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ jobs:
!contains(github.event.pull_request.head.ref, 'datadog-api-spec/test/')) ||
github.event_name == 'schedule'
uses: ./.github/workflows/reusable-pre-commit.yml
permissions:
id-token: write
contents: read
with:
enable-commit-changes: true
secrets:
PIPELINE_GITHUB_APP_ID: ${{ secrets.PIPELINE_GITHUB_APP_ID }}
PIPELINE_GITHUB_APP_PRIVATE_KEY: ${{ secrets.PIPELINE_GITHUB_APP_PRIVATE_KEY }}

test:
if: >
Expand All @@ -43,9 +43,6 @@ jobs:
python-versions: '["3.8", "3.12"]'
platforms: '["ubuntu-22.04", "ubuntu-latest", "macos-latest"]'
matrix-exclude: '[{"platform": "macos-latest", "python-version": "3.8"}, {"platform": "ubuntu-latest", "python-version": "3.8"}, {"platform": "ubuntu-22.04", "python-version": "3.12"}]'
secrets:
PIPELINE_GITHUB_APP_ID: ${{ secrets.PIPELINE_GITHUB_APP_ID }}
PIPELINE_GITHUB_APP_PRIVATE_KEY: ${{ secrets.PIPELINE_GITHUB_APP_PRIVATE_KEY }}

examples:
if: >
Expand All @@ -60,23 +57,23 @@ jobs:

report:
runs-on: ubuntu-latest
permissions:
id-token: write
if: always() && github.event_name == 'pull_request' && contains(github.event.pull_request.head.ref, 'datadog-api-spec/generated/')
needs:
- test
- examples
steps:
- name: Get GitHub App token
if: github.event_name == 'pull_request'
id: get_token
uses: actions/create-github-app-token@v1
- name: Get dd-octo-sts token
id: octo-sts
uses: DataDog/dd-octo-sts-action@96a25462dbcb10ebf0bfd6e2ccc917d2ab235b9a # v1.0.4
with:
app-id: ${{ secrets.PIPELINE_GITHUB_APP_ID }}
private-key: ${{ secrets.PIPELINE_GITHUB_APP_PRIVATE_KEY }}
repositories: datadog-api-spec
scope: DataDog/datadog-api-spec
policy: datadog-api-client-python.github.post-status-check.pull-request
- name: Post status check
uses: DataDog/github-actions/post-status-check@v2
with:
github-token: ${{ steps.get_token.outputs.token }}
github-token: ${{ steps.octo-sts.outputs.token }}
repo: datadog-api-spec
status: ${{ (needs.test.result == 'cancelled' || needs.examples.result == 'cancelled') && 'pending' || (needs.test.result == 'success' && needs.examples.result == 'success') && 'success' || 'failure' }}
context: master/unit
Loading