Conversation
duncanista
reviewed
Mar 11, 2025
duncanista
reviewed
Mar 11, 2025
| ) | ||
| .await | ||
| } else { | ||
| decrypt_aws_kms(&client, config.kms_api_key.clone(), aws_config).await |
Contributor
There was a problem hiding this comment.
Would KMS have the same issue? we are sending the aws_config which has the region config for the lambda
Contributor
Author
There was a problem hiding this comment.
The KMS string doesn't contain a region, the key ID is actually embedded in the ciphertext – so the aws API has to sort it out.
duncanista
approved these changes
Mar 11, 2025
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
LGTM – thanks for answering my comments!
This was referenced Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #594
you can verify with this function using a secret in us-east-1, while running in us-west-2.
Metrics appearing:
