[SVLS-4780] upstream Java sns and sqs refactor#538
Merged
Conversation
duncanista
reviewed
May 7, 2024
Contributor
Author
@duncanista 's comments made me take a closer look at the way i added debug logs. And after some thoughts I think it's best to use just one static string as the parameter and removed extra logging of the event payload or tracecontext. This is to avoid any extra memory allocation and keep the code cleaner. Based on my on-call experience, we usually get the event payload from other logs. |
duncanista
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extract trace context in SNS and SQS cases where the upstream service is instrumented by dd-trace-java
In short,
Java => SNS => Lambda, the env: _X_AMZN_TRACE_ID has the dd trace id but not the correct parent id. We will still use it here.Java => SQS => LambdaorJava => SNS => SQS => Lambdacase, AWS propagate the trace context in the json payload attributes.Longer version:
Testing Guidelines
Single Message Publish
Batch Publish

Additional Notes
Types of Changes
Check all that apply