Skip to content

Update dependencies#27

Merged
tianchu merged 1 commit intomasterfrom
tian.chu/update-dependencies
Nov 19, 2019
Merged

Update dependencies#27
tianchu merged 1 commit intomasterfrom
tian.chu/update-dependencies

Conversation

@tianchu
Copy link
Copy Markdown
Collaborator

@tianchu tianchu commented Nov 5, 2019

What does this PR do?

Update dependencies

Motivation

#26

@tianchu tianchu requested a review from a team as a code owner November 5, 2019 15:00
@tianchu tianchu mentioned this pull request Nov 5, 2019
@mbelang
Copy link
Copy Markdown

mbelang commented Nov 5, 2019

Hi @tianchu. Do you have an estimate on this as it is a blocker for us right now. Than you

@tianchu
Copy link
Copy Markdown
Collaborator Author

tianchu commented Nov 5, 2019

@mbelang Do you use pip or a requirements.txt to manage python dependencies? If so, you can list ddtrace with the desired version in your projects' requirements.txt directly, which would override the ddtrace provided by the layer.

@mbelang
Copy link
Copy Markdown

mbelang commented Nov 5, 2019

No i'm not. We are using poetry which does a better job a dependency resolution and there is obviously a conflict between our lib and this one as our lib uses the latest of datadog's

@tianchu
Copy link
Copy Markdown
Collaborator Author

tianchu commented Nov 5, 2019

So you installs datadog-lambda using poetry? Does this workaround work for you python-poetry/poetry#697?

You can also probably remove datadog-lambda from poetry, but instead use our serverless framework plugin: https://github.com/DataDog/serverless-plugin-datadog. Our plugin will install datadog-lambda as a AWS Lambda Layer instead of a python package, which would avoid causing conflicts with your own dependencies.

@mbelang
Copy link
Copy Markdown

mbelang commented Nov 5, 2019

I decided to install datadog-lambda from git instead. I'm testing it ATM

@tianchu tianchu force-pushed the tian.chu/update-dependencies branch from 8ffa6a8 to e403042 Compare November 14, 2019 20:09
@tianchu
Copy link
Copy Markdown
Collaborator Author

tianchu commented Nov 14, 2019

The upgrade is blocked by a bug in the latest version (0.31.0) of datadogpy: DataDog/datadogpy#480

@tianchu tianchu force-pushed the tian.chu/update-dependencies branch from e403042 to 980b13a Compare November 19, 2019 15:38
@tianchu tianchu changed the title [WIP] [DO NOT MERGE] Update dependencies Update dependencies Nov 19, 2019
@tianchu tianchu merged commit 284d874 into master Nov 19, 2019
@tianchu tianchu deleted the tian.chu/update-dependencies branch November 19, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants